Refactor Hydrogen GVN into an HPhase and use the phase zone.

src/hydrogen.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 266 matching lines @@
   HEnvironment* start_environment() const { return start_environment_; }
 
   void FinalizeUniqueValueIds();
   void InitializeInferredTypes();
   void InsertTypeConversions();
   void MergeRemovableSimulates();
   void InsertRepresentationChanges();
   void MarkDeoptimizeOnUndefined();
   void ComputeMinusZeroChecks();
   void ComputeSafeUint32Operations();
-  void GlobalValueNumbering();
   bool ProcessArgumentsObject();
   void EliminateRedundantPhis();
   void Canonicalize();
   void OrderBlocks();
   void AssignDominators();
   void SetupInformativeDefinitions();
   void EliminateRedundantBoundsChecks();
   void DehoistSimpleArrayIndexComputations();
   void RestoreActualValues();
   void DeadCodeElimination(const char *phase_name);
@@ skipping 123 matching lines @@
     if (uint32_instructions_ == NULL) {
       uint32_instructions_ = new(zone()) ZoneList<HInstruction*>(4, zone());
     }
     uint32_instructions_->Add(instr, zone());
   }
 
  private:
   HConstant* GetConstant(SetOncePointer<HConstant>* pointer,
                          int32_t integer_value);
 
+  template<typename Phase>
+  void Run() { Phase phase(this, info()->phase_zone()); phase.Run(); }

[danno, 2013/06/25 15:20:54]

Isn't this from another CL?

[Benedikt Meurer, 2013/06/27 08:20:04]

Done.

   void MarkLive(HValue* ref, HValue* instr, ZoneList<HValue*>* worklist);
   void MarkLiveInstructions();
   void RemoveDeadInstructions();
   void MarkAsDeoptimizingRecursively(HBasicBlock* block);
   void NullifyUnreachableInstructions();
   void InsertTypeConversions(HInstruction* instr);
   void PropagateMinusZeroChecks(HValue* value, BitVector* visited);
   void RecursivelyMarkPhiDeoptimizeOnUndefined(HPhi* phi);
   void InsertRepresentationChangeForUse(HValue* value,
                                         HValue* use_value,
@@ skipping 1509 matching lines @@
   int64_t optimize_graph_;
   int64_t generate_code_;
   unsigned total_size_;
   int64_t full_code_gen_;
   double source_size_;
 };
 
 
 class HPhase : public CompilationPhase {
  public:
+  // TODO(bmeurer) Remove this constructor once all
+  // Hydrogen phases have been migrated
   HPhase(const char* name, HGraph* graph)
       : CompilationPhase(name, graph->isolate(), graph->zone()),
         graph_(graph) { }
+  HPhase(const char* name, HGraph* graph, Zone* zone);

[danno, 2013/06/25 15:20:54]

again, why do you need to pass the zone in? Either you need the graph zone (with
graph->zone()) or the phase zone (graph->info()->phase_zone()). Either way, you
shouldn't have to pass it in explicitly.

[Benedikt Meurer, 2013/06/27 08:20:04]

Done.

   ~HPhase();
 
+ protected:
+  HGraph* graph() const { return graph_; }
+
  private:
   HGraph* graph_;
+  unsigned graph_zone_start_allocation_size_;
 
   DISALLOW_COPY_AND_ASSIGN(HPhase);
 };
 
 
 class HTracer: public Malloced {
  public:
   explicit HTracer(int isolate_id)
       : trace_(&string_allocator_), indent_(0) {
     OS::SNPrintF(filename_,
@@ skipping 70 matching lines @@
   EmbeddedVector<char, 64> filename_;
   HeapStringAllocator string_allocator_;
   StringStream trace_;
   int indent_;
 };
 
 
 } }  // namespace v8::internal
 
 #endif  // V8_HYDROGEN_H_