Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 1765693002: Revert of IPC::ParamTraits for ui::Event (towards ui::Events over mojo IPC) (Closed)

Created:
4 years, 9 months ago by Dmitry Titov
Modified:
4 years, 9 months ago
CC:
chromium-reviews, tdresser+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of IPC::ParamTraits for ui::Event (towards ui::Events over mojo IPC) (patchset #18 id:340001 of https://codereview.chromium.org/1695783002/ ) Reason for revert: Breaks compile: https://build.chromium.org/p/chromium.win/builders/Win%20x64%20GN%20%28dbg%29/builds/19183 Original issue's description: > Implements and tests IPC::ParamTraits for ui::Event (towards ui::Events over mojo IPC). Support for (scoped) pointers for abstract ui::Event objects implemented using ui::ScopedEvent, and trusting ui::EventType information to instantiate the correct concrete type. > > BUG=584687 > > Committed: https://crrev.com/482ddfefe2602f440146eebf4b56e8e040fb81fa > Cr-Commit-Position: refs/heads/master@{#378821} > > Committed: https://crrev.com/74b231ad33ec44bc2662fef2831a3cd90e1f3834 > Cr-Commit-Position: refs/heads/master@{#379094} TBR=rockot@chromium.org,sadrul@chromium.org,kenrb@chromium.org,tsepez@chromium.org,jam@chromium.org,sky@chromium.org,fsamuel@chromium.org,markdittmer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=584687 Committed: https://crrev.com/6b7bd07d9d9494437e901881d3938297b261bb98 Cr-Commit-Position: refs/heads/master@{#379123}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -1132 lines) Patch
M ash/mus/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/BUILD.gn View 3 chunks +4 lines, -4 lines 0 comments Download
M components/mus/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/common/BUILD.gn View 1 chunk +1 line, -34 lines 0 comments Download
M components/mus/common/args.cc View 1 chunk +1 line, -2 lines 0 comments Download
D components/mus/common/event_param_traits.h View 1 chunk +0 lines, -95 lines 0 comments Download
D components/mus/common/event_param_traits.cc View 1 chunk +0 lines, -277 lines 0 comments Download
D components/mus/common/event_param_traits_macros.h View 1 chunk +0 lines, -101 lines 0 comments Download
D components/mus/common/event_param_traits_unittest.cc View 1 chunk +0 lines, -468 lines 0 comments Download
D components/mus/common/mus_common_export.h View 1 chunk +0 lines, -29 lines 0 comments Download
M components/mus/public/cpp/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/public/cpp/tests/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/ws/BUILD.gn View 4 chunks +4 lines, -4 lines 0 comments Download
M mash/wm/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/event.h View 13 chunks +3 lines, -67 lines 0 comments Download
M ui/events/event.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/events/events.gyp View 2 chunks +1 line, -2 lines 0 comments Download
M ui/events/gesture_event_details.h View 3 chunks +0 lines, -18 lines 0 comments Download
M ui/events/ipc/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M ui/events/keycodes/dom/dom_key.h View 2 chunks +0 lines, -3 lines 0 comments Download
M ui/gfx/ipc/gfx_param_traits.h View 3 chunks +0 lines, -3 lines 0 comments Download
M ui/gfx/ipc/gfx_param_traits.cc View 3 chunks +0 lines, -16 lines 0 comments Download
M ui/metro_viewer/metro_viewer_messages.h View 2 chunks +19 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Dmitry Titov
Created Revert of IPC::ParamTraits for ui::Event (towards ui::Events over mojo IPC)
4 years, 9 months ago (2016-03-03 22:39:09 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1765693002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1765693002/1
4 years, 9 months ago (2016-03-03 22:39:34 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-03 22:40:50 UTC) #3
commit-bot: I haz the power
4 years, 9 months ago (2016-03-03 22:42:37 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6b7bd07d9d9494437e901881d3938297b261bb98
Cr-Commit-Position: refs/heads/master@{#379123}

Powered by Google App Engine
This is Rietveld 408576698