Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Unified Diff: docs/ios_build_instructions.md

Issue 1765633005: docs: less confusing sentence for running `gclient sync` command (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: docs/ios_build_instructions.md
diff --git a/docs/ios_build_instructions.md b/docs/ios_build_instructions.md
index 0f772a13c7516ed9e9ed9fafc0aa0b5863dc9069..dba0e223dfe6a22a3aedbe03acc1f222e809be5a 100644
--- a/docs/ios_build_instructions.md
+++ b/docs/ios_build_instructions.md
@@ -92,8 +92,8 @@ out/Debug-iphonesimulator/iossim out/Debug-iphonesimulator/ios_web_shell.app
## Converting an existing Mac checkout into an iOS checkout
-If you want to convert your Mac checkout into an iOS checkout, you can
-follow those steps:
+If you want to convert your Mac checkout into an iOS checkout, follow the steps
+below:
1. Add `target_os = [ "ios" ]` to the bottom of your `chromium/.gclient`
sdefresne 2016/03/04 18:09:51 nit: like bulleted list, this need to be indented
tfarina 2016/03/04 18:47:57 Ah, that is very true. Thanks for noticing. Both a
file.
@@ -109,9 +109,8 @@ developer-signed builds):
}
```
-Then make sure you sync again to get all the new files like the following. At
-the end it will run `build/gyp_chromium` which will regenerate all the build
-files according to the new settings.
+3. Make sure to sync again to fetch the iOS specific dependencies and
+regenerate build rules using:
```shell
gclient sync
@@ -120,6 +119,6 @@ gclient sync
## Troubleshooting
If your build fails, check the iOS columns of [the Mac
-waterfall](http://build.chromium.org/p/chromium.mac/console) (the last
-two) to see if the bots are green. In general they should be, since
-failures on those bots will close the tree.
+waterfall](http://build.chromium.org/p/chromium.mac/console) (the last two) to
+see if the bots are green. In general they should be, since failures on those
+bots will close the tree.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698