docs: less confusing sentence for running `gclient sync` command

docs: less confusing sentence for running `gclient sync` command

This patch tries to clear the last paragraph of
"Converting-an-existing-Mac-checkout-into-an-iOS-checkout" section,
to be more to the point and slightly more accurate in the future.

Given that at some point into the not-so-distant future GN will replace
GYP, the word about "gyp_chromium" won't be necessarily true anymore.

It does not seem worth to mention this implementation detail of 'gclient
sync'.

BUG=None
R=sdefresne@chromium.org

Committed: https://crrev.com/b3456c7707a021dcb7fbd5f2af2524c452934c49
Cr-Commit-Position: refs/heads/master@{#379332}

[tfarina, 2016-03-04 17:59:50]

Hopefully, this should be good to go.

[sdefresne, 2016-03-04 18:09:51]

lgtm

https://codereview.chromium.org/1765633005/diff/1/docs/ios_build_instructions.md
File docs/ios_build_instructions.md (right):

https://codereview.chromium.org/1765633005/diff/1/docs/ios_build_instructions...
docs/ios_build_instructions.md:98: 1. Add `target_os = [ "ios" ]` to the bottom
of your `chromium/.gclient`
nit: like bulleted list, this need to be indented like this:

1.  Add `target_os = [ "ios" ]` to the bottom of your `chromium/.gclient`
    file.

1.  Make sure you have the following in your `chromium/chromium.gyp_env`
    file (removing the `chromium_ios_signing=0` if you want to make
    developer-signed builds):

[tfarina, 2016-03-04 18:47:58]

https://codereview.chromium.org/1765633005/diff/1/docs/ios_build_instructions.md
File docs/ios_build_instructions.md (right):

https://codereview.chromium.org/1765633005/diff/1/docs/ios_build_instructions...
docs/ios_build_instructions.md:98: 1. Add `target_os = [ "ios" ]` to the bottom
of your `chromium/.gclient`
On 2016/03/04 18:09:51, sdefresne wrote:
> nit: like bulleted list, this need to be indented like this:
> 
> 1.  Add `target_os = [ "ios" ]` to the bottom of your `chromium/.gclient`
>     file.
> 
> 1.  Make sure you have the following in your `chromium/chromium.gyp_env`
>     file (removing the `chromium_ios_signing=0` if you want to make
>     developer-signed builds):

Ah, that is very true. Thanks for noticing. Both are recommeded by the style
guide. Fixed.

[tfarina, 2016-03-04 18:48:20]

The CQ bit was checked by tfarina@chromium.org

[tfarina, 2016-03-04 18:48:21]

The patchset sent to the CQ was uploaded after l-g-t-m from
sdefresne@chromium.org
Link to the patchset: https://codereview.chromium.org/1765633005/#ps20001
(title: "lazy numbering and 2 spaces after a numbered list")

[commit-bot: I haz the power, 2016-03-04 18:48:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1765633005/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1765633005/20001

[commit-bot: I haz the power, 2016-03-04 19:36:11]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-04 19:37:18]

Description was changed from

==========
docs: less confusing sentence for running `gclient sync` command

This patch tries to clear the last paragraph of
"Converting-an-existing-Mac-checkout-into-an-iOS-checkout" section,
to be more to the point and slightly more accurate in the future.

Given that at some point into the not-so-distant future GN will replace
GYP, the word about "gyp_chromium" won't be necessarily true anymore.

It does not seem worth to mention this implementation detail of 'gclient
sync'.

BUG=None
R=sdefresne@chromium.org
==========

to

==========
docs: less confusing sentence for running `gclient sync` command

This patch tries to clear the last paragraph of
"Converting-an-existing-Mac-checkout-into-an-iOS-checkout" section,
to be more to the point and slightly more accurate in the future.

Given that at some point into the not-so-distant future GN will replace
GYP, the word about "gyp_chromium" won't be necessarily true anymore.

It does not seem worth to mention this implementation detail of 'gclient
sync'.

BUG=None
R=sdefresne@chromium.org

Committed: https://crrev.com/b3456c7707a021dcb7fbd5f2af2524c452934c49
Cr-Commit-Position: refs/heads/master@{#379332}
==========

[commit-bot: I haz the power, 2016-03-04 19:37:19]

Patchset 2 (id:??) landed as
https://crrev.com/b3456c7707a021dcb7fbd5f2af2524c452934c49
Cr-Commit-Position: refs/heads/master@{#379332}

[tfarina, 2016-03-04 20:59:00]

https://codereview.chromium.org/1765633005/diff/20001/docs/ios_build_instruct...
File docs/ios_build_instructions.md (right):

https://codereview.chromium.org/1765633005/diff/20001/docs/ios_build_instruct...
docs/ios_build_instructions.md:112: 1.  Make sure to sync again to fetch the iOS
specific dependencies and
Looking at the result [1], it now shows 1., 2., 1., which is bad. Sorry for not
previewing it before :/

Either we make 1., 2., 3., or just remove the number here.

What is your preference Sylvain?

[1] -
https://chromium.googlesource.com/chromium/src/+/master/docs/ios_build_instru...

[tfarina, 2016-03-04 21:03:27]

https://codereview.chromium.org/1765633005/diff/20001/docs/ios_build_instruct...
File docs/ios_build_instructions.md (right):

https://codereview.chromium.org/1765633005/diff/20001/docs/ios_build_instruct...
docs/ios_build_instructions.md:44: Also, you should [install API
Another question: here we say "should". But should we say that?

Is it really required? It won't build if the api-keys are not installed?

mac has a much less strong wording here: "you may want to install API keys..."
though.

[sdefresne, 2016-03-07 10:08:14]

On 2016/03/04 at 21:03:27, tfarina wrote:
>
https://codereview.chromium.org/1765633005/diff/20001/docs/ios_build_instruct...
> File docs/ios_build_instructions.md (right):
> 
>
https://codereview.chromium.org/1765633005/diff/20001/docs/ios_build_instruct...
> docs/ios_build_instructions.md:44: Also, you should [install API
> Another question: here we say "should". But should we say that?
> 
> Is it really required? It won't build if the api-keys are not installed?
> 
> mac has a much less strong wording here: "you may want to install API keys..."
though.

No, it is not required, it will build fine without. We can probably use the same
wording as Mac I guess.

[sdefresne, 2016-03-07 16:50:56]

On 2016/03/04 at 20:59:00, tfarina wrote:
>
https://codereview.chromium.org/1765633005/diff/20001/docs/ios_build_instruct...
> File docs/ios_build_instructions.md (right):
> 
>
https://codereview.chromium.org/1765633005/diff/20001/docs/ios_build_instruct...
> docs/ios_build_instructions.md:112: 1.  Make sure to sync again to fetch the
iOS specific dependencies and
> Looking at the result [1], it now shows 1., 2., 1., which is bad. Sorry for
not previewing it before :/
> 
> Either we make 1., 2., 3., or just remove the number here.
> 
> What is your preference Sylvain?
> 
> [1] -
https://chromium.googlesource.com/chromium/src/+/master/docs/ios_build_instru...

I think we should do 1., 2., 3.