Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1765633004: Avoid duplicate lookups when Get+Creating identity hashes (Closed)

Created:
4 years, 9 months ago by Toon Verwaest
Modified:
4 years, 9 months ago
Reviewers:
Camillo Bruni
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Avoid duplicate lookups when Get+Creating identity hashes BUG= Committed: https://crrev.com/78e23b2b9e46f455604a6d5c94b614d27076493c Cr-Commit-Position: refs/heads/master@{#34500}

Patch Set 1 #

Patch Set 2 : tweaks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -24 lines) Patch
M src/objects.h View 2 chunks +2 lines, -5 lines 0 comments Download
M src/objects.cc View 1 3 chunks +10 lines, -19 lines 0 comments Download
M src/objects-inl.h View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Toon Verwaest
ptal
4 years, 9 months ago (2016-03-04 14:42:02 UTC) #2
Camillo Bruni
lgtm
4 years, 9 months ago (2016-03-04 14:48:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1765633004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1765633004/20001
4 years, 9 months ago (2016-03-04 14:53:10 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-04 15:14:53 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-04 15:15:04 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/78e23b2b9e46f455604a6d5c94b614d27076493c
Cr-Commit-Position: refs/heads/master@{#34500}

Powered by Google App Engine
This is Rietveld 408576698