Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 1765633003: [LookupIterator] Add fast-path for reloading accessor property information (Closed)

Created:
4 years, 9 months ago by Toon Verwaest
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[LookupIterator] Add fast-path for reloading accessor property information This is the equivalent of the fast-path in ApplyTransitionToDataProperty. BUG=588893, 325923 LOG=n Committed: https://crrev.com/7011ddd6528ce75491228efc001790090a8bb947 Cr-Commit-Position: refs/heads/master@{#34488}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M src/lookup.cc View 1 chunk +9 lines, -1 line 1 comment Download

Messages

Total messages: 11 (4 generated)
Toon Verwaest
cbruni: ptal eisinger, peria: fyi
4 years, 9 months ago (2016-03-04 09:55:10 UTC) #2
jochen (gone - plz use gerrit)
https://codereview.chromium.org/1765633003/diff/1/src/lookup.cc File src/lookup.cc (right): https://codereview.chromium.org/1765633003/diff/1/src/lookup.cc#newcode375 src/lookup.cc:375: int number = new_map->LastAdded(); why's LastAdded not return uint32_t?
4 years, 9 months ago (2016-03-04 09:58:03 UTC) #4
Toon Verwaest
Traditionally descriptor lookup has always been int. I never updated it since the fast that ...
4 years, 9 months ago (2016-03-04 10:00:24 UTC) #5
jochen (gone - plz use gerrit)
lgtm
4 years, 9 months ago (2016-03-04 10:01:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1765633003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1765633003/1
4 years, 9 months ago (2016-03-04 10:02:16 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-04 10:39:58 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-04 10:41:25 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7011ddd6528ce75491228efc001790090a8bb947
Cr-Commit-Position: refs/heads/master@{#34488}

Powered by Google App Engine
This is Rietveld 408576698