Don't allow nullptr in texels array params (unless using a transfer buffer).

Don't allow nullptr in texels array params (unless using a transfer buffer).

Require all levels in writePixels to have a non-nullptr.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1765633002

Committed: https://skia.googlesource.com/skia/+/8ee78f31b2a29a5f76403755ea17bad9be74a3ec

Committed: https://skia.googlesource.com/skia/+/e699d0cd25fd059e3f0c4949e613e50c83a52179

[bsalomon, 2016-03-03 20:48:29]

Description was changed from

==========
Don't allow nullptr in texels array params (unless using a transfer buffer).

Require all levels in writePixels to have a non-nullptr.
==========

to

==========
Don't allow nullptr in texels array params (unless using a transfer buffer).

Require all levels in writePixels to have a non-nullptr.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[bsalomon, 2016-03-03 20:51:21]

Patchset #2 (id:20001) has been deleted

[bsalomon, 2016-03-03 20:55:03]

bsalomon@google.com changed reviewers:
+ cblume@google.com, jvanverth@google.com

[cblume, 2016-03-03 22:54:46]

cblume@chromium.org changed reviewers:
+ cblume@chromium.org

[cblume, 2016-03-03 22:54:46]

https://codereview.chromium.org/1765633002/diff/40001/src/gpu/GrGpu.cpp
File src/gpu/GrGpu.cpp (right):

https://codereview.chromium.org/1765633002/diff/40001/src/gpu/GrGpu.cpp#newco...
src/gpu/GrGpu.cpp:191: return this->createTexture(desc, budgeted,
SkTArray<GrMipLevel>());
I'm not sure I understand this bit.
Won't this be calling it with an empty texels array rather than with just the
one mipmap level from the srcData?

[bsalomon, 2016-03-03 23:02:40]

https://codereview.chromium.org/1765633002/diff/40001/src/gpu/GrGpu.cpp
File src/gpu/GrGpu.cpp (right):

https://codereview.chromium.org/1765633002/diff/40001/src/gpu/GrGpu.cpp#newco...
src/gpu/GrGpu.cpp:191: return this->createTexture(desc, budgeted,
SkTArray<GrMipLevel>());
On 2016/03/03 22:54:46, cblume wrote:
> I'm not sure I understand this bit.
> Won't this be calling it with an empty texels array rather than with just the
> one mipmap level from the srcData?

Oops, I fixed this locally but uploaded without. Will fix.

[bsalomon, 2016-03-03 23:41:05]

PTAL

[bsalomon, 2016-03-03 23:42:21]

The CQ bit was checked by bsalomon@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-03-03 23:42:27]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1765633002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1765633002/60001

[cblume, 2016-03-03 23:47:01]

On 2016/03/03 23:41:05, bsalomon wrote:
> PTAL

Okay, I follow now.
lgtm :)

[commit-bot: I haz the power, 2016-03-03 23:53:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-03 23:54:00]

Dry run: This issue passed the CQ dry run.

[bsalomon, 2016-03-04 14:22:05]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2016-03-04 14:22:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1765633002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1765633002/60001

[commit-bot: I haz the power, 2016-03-04 14:23:38]

Description was changed from

==========
Don't allow nullptr in texels array params (unless using a transfer buffer).

Require all levels in writePixels to have a non-nullptr.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Don't allow nullptr in texels array params (unless using a transfer buffer).

Require all levels in writePixels to have a non-nullptr.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/8ee78f31b2a29a5f76403755ea17bad9be74a3ec
==========

[commit-bot: I haz the power, 2016-03-04 14:23:39]

Committed patchset #3 (id:60001) as
https://skia.googlesource.com/skia/+/8ee78f31b2a29a5f76403755ea17bad9be74a3ec

[bsalomon, 2016-03-04 15:06:35]

A revert of this CL (patchset #3 id:60001) has been created in
https://codereview.chromium.org/1760343003/ by bsalomon@google.com.

The reason for reverting is: breaks vk build.

[bsalomon, 2016-03-09 13:58:09]

Description was changed from

==========
Don't allow nullptr in texels array params (unless using a transfer buffer).

Require all levels in writePixels to have a non-nullptr.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/8ee78f31b2a29a5f76403755ea17bad9be74a3ec
==========

to

==========
Don't allow nullptr in texels array params (unless using a transfer buffer).

Require all levels in writePixels to have a non-nullptr.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/8ee78f31b2a29a5f76403755ea17bad9be74a3ec
==========

[bsalomon, 2016-03-09 13:58:15]

The CQ bit was checked by bsalomon@google.com

[bsalomon, 2016-03-09 13:58:16]

The patchset sent to the CQ was uploaded after l-g-t-m from cblume@chromium.org
Link to the patchset: https://codereview.chromium.org/1765633002/#ps100001
(title: "Upload again in case prev didn't work")

[commit-bot: I haz the power, 2016-03-09 13:58:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1765633002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1765633002/100001

[commit-bot: I haz the power, 2016-03-09 14:25:18]

Description was changed from

==========
Don't allow nullptr in texels array params (unless using a transfer buffer).

Require all levels in writePixels to have a non-nullptr.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/8ee78f31b2a29a5f76403755ea17bad9be74a3ec
==========

to

==========
Don't allow nullptr in texels array params (unless using a transfer buffer).

Require all levels in writePixels to have a non-nullptr.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/8ee78f31b2a29a5f76403755ea17bad9be74a3ec

Committed:
https://skia.googlesource.com/skia/+/e699d0cd25fd059e3f0c4949e613e50c83a52179
==========

[commit-bot: I haz the power, 2016-03-09 14:25:22]

Committed patchset #5 (id:100001) as
https://skia.googlesource.com/skia/+/e699d0cd25fd059e3f0c4949e613e50c83a52179