Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 176563002: Revert r252832: Eliminate Bookmarks dependence to bookmark_undo_utils.h. (Closed)

Created:
6 years, 10 months ago by dcheng
Modified:
6 years, 10 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, browser-components-watch_chromium.org, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Revert r252832: Eliminate Bookmarks dependence to bookmark_undo_utils.h. BookmarkUtilsTest.CutToClipboard is failing on Android: ../../chrome/browser/bookmarks/bookmark_utils_unittest.cc:37: Failure Value of: expected_beginning_count Actual: 1 Expected: grouped_changes_beginning_count_ Which is: 0 ../../chrome/browser/bookmarks/bookmark_utils_unittest.cc:38: Failure Value of: expected_ended_count Actual: 1 Expected: grouped_changes_ended_count_ Which is: 0 TBR=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252852

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -163 lines) Patch
M chrome/browser/bookmarks/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_model.h View 3 chunks +0 lines, -7 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_model.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_model_observer.h View 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_utils.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/bookmarks/bookmark_utils.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_utils_unittest.cc View 3 chunks +2 lines, -50 lines 0 comments Download
D chrome/browser/bookmarks/scoped_group_bookmark_actions.h View 1 chunk +0 lines, -26 lines 0 comments Download
D chrome/browser/bookmarks/scoped_group_bookmark_actions.cc View 1 chunk +0 lines, -27 lines 0 comments Download
M chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/bookmarks/bookmark_drag_drop.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/undo/bookmark_undo_service.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/undo/bookmark_undo_service.cc View 3 chunks +11 lines, -21 lines 0 comments Download
M chrome/browser/undo/bookmark_undo_utils.h View 1 chunk +14 lines, -0 lines 0 comments Download
M chrome/browser/undo/bookmark_undo_utils.cc View 1 chunk +15 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
dcheng
Committed patchset #1 manually as r252852 (tree was closed).
6 years, 10 months ago (2014-02-23 11:02:52 UTC) #1
Tom Cassiotis
6 years, 10 months ago (2014-02-23 12:45:34 UTC) #2
Message was sent while issue was closed.
On 2014/02/23 11:02:52, dcheng wrote:
> Committed patchset #1 manually as r252852 (tree was closed).

The undo is not included for Android and so the call to ExpectGroupedChangeCount
should likewise be excluded.

#if !defined(OS_ANDROID)
  // Make sure observers were notified the set of changes should be grouped.
  ExpectGroupedChangeCount(1, 1);
#endif

I will push up the correction to the original code review
https://codereview.chromium.org/155913004/

Powered by Google App Engine
This is Rietveld 408576698