ABANDONED CL: Fix delivery of TestFinishedInSecondaryWindow message from OOPIFs.

content/common/swapped_out_messages.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/common/swapped_out_messages.h"
 
 #include "content/common/accessibility_messages.h"
 #include "content/common/frame_messages.h"
 #include "content/common/input_messages.h"
 #include "content/common/view_messages.h"
 #include "content/public/common/content_client.h"
 #include "content/shell/common/shell_messages.h"

[jochen (gone - plz use gerrit), 2016/03/08 16:33:18]

WAT?

can you please introduce a ContentClient callback and override that from content
shell? content musn't depend on shell

[Łukasz Anforowicz, 2016/03/08 17:31:06]

Hmmm... good point.  How could I miss that... :-/

1. I am trying to tighten DEPS rules in
https://codereview.chromium.org/1777503003/

2. nasko@ says that this extra temporary hole in swapped out processing might be
ok (he plans to yank out swapped out in the next few weeks).

3. before proceeding, I probably should double-check why we end up sending a
message in swapped out state here.  For example - what exactly causes the test
to finish?  If test finishes because of didFinishLoad, then is
TestRunner::topLoadingFrame a main frame?  Is it ok if it is not a main frame? 
Maybe we should communicate with the browser via a randomly-picked local frame
(just as we do in https://codereview.chromium.org/1715573002/#msg9)?

 
 namespace content {
 
 bool SwappedOutMessages::CanSendWhileSwappedOut(const IPC::Message* msg) {
   // We filter out most IPC messages when swapped out.  However, some are
   // important (e.g., ACKs) for keeping the browser and renderer state
   // consistent in case we later return to the same renderer.
   switch (msg->type()) {
     // Handled by RenderWidgetHost.
     case InputHostMsg_HandleInputEvent_ACK::ID:
@@ skipping 21 matching lines @@
     case FrameHostMsg_ForwardInputEvent::ID:
     case FrameHostMsg_InitializeChildFrame::ID:
     // The browser should always have an accurate mirror of the renderer's
     // notion of the current page id.
     case FrameHostMsg_DidAssignPageId::ID:
     // A swapped-out frame's opener might be updated with window.open.
     case FrameHostMsg_DidChangeOpener::ID:
     // Used in layout tests; handled in BlinkTestController.
     case ShellViewHostMsg_PrintMessage::ID:
     case ShellViewHostMsg_LayoutDumpFlagsChanged::ID:
+    case ShellViewHostMsg_TestFinishedInSecondaryRenderer::ID:
       return true;
     default:
       break;
   }
 
   // Check with the embedder as well.
   ContentClient* client = GetContentClient();
   return client->CanSendWhileSwappedOut(msg);
 }
 
@@ skipping 28 matching lines @@
     case AccessibilityHostMsg_Events::ID:
       return true;
     default:
       break;
   }
 
   return false;
 }
 
 }  // namespace content