Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 176553003: Remove unused WorkerGlobalScope::m_domURL field. (Closed)

Created:
6 years, 10 months ago by sof
Modified:
6 years, 10 months ago
CC:
blink-reviews, kinuko+watch
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove unused WorkerGlobalScope::m_domURL field. The URL constructor is now available via the generated bindings. R=mkwst@chromium.org BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167647

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
Source/core/workers/WorkerGlobalScope.h View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
sof
Please take a look. (Spotted while translating Worker interfaces to Oilpan.)
6 years, 10 months ago (2014-02-23 15:20:33 UTC) #1
Mike West
LGTM, thanks for removing this cruft.
6 years, 10 months ago (2014-02-23 16:07:46 UTC) #2
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 10 months ago (2014-02-23 16:12:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/176553003/1
6 years, 10 months ago (2014-02-23 16:12:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/176553003/1
6 years, 10 months ago (2014-02-23 17:02:53 UTC) #5
commit-bot: I haz the power
6 years, 10 months ago (2014-02-23 17:36:23 UTC) #6
Message was sent while issue was closed.
Change committed as 167647

Powered by Google App Engine
This is Rietveld 408576698