Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 1765463002: One instead of three resolverChanged replacing source in inspector. (Closed)

Created:
4 years, 9 months ago by rune
Modified:
4 years, 9 months ago
Reviewers:
esprehn, pfeldman
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, dglazkov+blink, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, rwlbuis, sergeyv+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

One instead of three resolverChanged replacing source in inspector. resolverChanged() was called three times when replacing the stylesheet text from the inspector. Two mutation scopes and an explicit call at the end. Kept one of the mutation scopes. Two shouldn't be necessary, and I have confirmed that the crash tests for which this was justified earlier don't crash when removing one of the scopes. Moved the stylesheet modifications into CSSStyleSheet::setText(). Also moved clearing of the CSSOM wrappers before the mutation scope declaration as the mutation scope constructor would unnecessarily re-attach wrappers which would then be cleared right after. R=esprehn@chromium.org,pfeldman@chromium.org BUG=591599 Committed: https://crrev.com/5958ca8683dd9478a780d516205355a36c48c5aa Cr-Commit-Position: refs/heads/master@{#378978}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -19 lines) Patch
M third_party/WebKit/Source/core/css/CSSStyleSheet.h View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSStyleSheet.cpp View 2 chunks +9 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorStyleSheet.cpp View 1 chunk +2 lines, -12 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1765463002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1765463002/1
4 years, 9 months ago (2016-03-03 02:26:50 UTC) #2
rune
ptal
4 years, 9 months ago (2016-03-03 02:42:10 UTC) #4
pfeldman
lgtm
4 years, 9 months ago (2016-03-03 02:49:55 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-03 03:37:40 UTC) #7
esprehn
lgtm
4 years, 9 months ago (2016-03-03 04:08:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1765463002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1765463002/1
4 years, 9 months ago (2016-03-03 07:35:50 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-03 07:41:27 UTC) #12
commit-bot: I haz the power
4 years, 9 months ago (2016-03-03 07:42:56 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5958ca8683dd9478a780d516205355a36c48c5aa
Cr-Commit-Position: refs/heads/master@{#378978}

Powered by Google App Engine
This is Rietveld 408576698