Chromium Code Reviews| Index: Source/core/dom/Element.cpp |
| diff --git a/Source/core/dom/Element.cpp b/Source/core/dom/Element.cpp |
| index 921392e15075276481840f28c6b872207fe33766..01365d2476de016e02ce0af7a6a7d800d8a0e17a 100644 |
| --- a/Source/core/dom/Element.cpp |
| +++ b/Source/core/dom/Element.cpp |
| @@ -205,6 +205,7 @@ Element::~Element() |
| ElementRareData* data = elementRareData(); |
| data->setPseudoElement(BEFORE, 0); |
| data->setPseudoElement(AFTER, 0); |
| + data->setPseudoElement(BACKDROP, 0); |
| data->clearShadow(); |
| } |
| @@ -1292,7 +1293,10 @@ void Element::removedFrom(ContainerNode* insertionPoint) |
| if (Element* after = pseudoElement(AFTER)) |
| after->removedFrom(insertionPoint); |
| + if (Element* backdrop = pseudoElement(BACKDROP)) |
| + backdrop->removedFrom(insertionPoint); |
| document()->removeFromTopLayer(this); |
| + |
| if (containsFullScreenElement()) |
| setContainsFullScreenElementOnAncestorsCrossingFrameBoundaries(false); |
| @@ -1350,6 +1354,7 @@ void Element::attach(const AttachContext& context) |
| ContainerNode::attach(context); |
| createPseudoElementIfNeeded(AFTER); |
| + createPseudoElementIfNeeded(BACKDROP); |
| if (hasRareData()) { |
| ElementRareData* data = elementRareData(); |
| @@ -1382,6 +1387,7 @@ void Element::detach(const AttachContext& context) |
| ElementRareData* data = elementRareData(); |
| data->setPseudoElement(BEFORE, 0); |
| data->setPseudoElement(AFTER, 0); |
| + data->setPseudoElement(BACKDROP, 0); |
| data->setIsInCanvasSubtree(false); |
| data->resetComputedStyle(); |
| data->resetDynamicRestyleObservations(); |
| @@ -2423,7 +2429,10 @@ void Element::updatePseudoElement(PseudoId pseudoId, StyleChange change) |
| void Element::createPseudoElementIfNeeded(PseudoId pseudoId) |
| { |
| - if (!document()->styleSheetCollection()->usesBeforeAfterRules()) |
| + if ((pseudoId == BEFORE || pseudoId == AFTER) && !document()->styleSheetCollection()->usesBeforeAfterRules()) |
| + return; |
| + |
| + if (pseudoId == BACKDROP && !isInTopLayer()) |
| return; |
| if (!renderer() || !pseudoElementRendererIsNeeded(renderer()->getCachedPseudoStyle(pseudoId))) |
| @@ -2436,6 +2445,9 @@ void Element::createPseudoElementIfNeeded(PseudoId pseudoId) |
| RefPtr<PseudoElement> element = PseudoElement::create(this, pseudoId); |
| element->attach(); |
| ensureElementRareData()->setPseudoElement(pseudoId, element.release()); |
| + |
| + if (pseudoId == BACKDROP) |
| + document()->addToTopLayer(pseudoElement(BACKDROP), this); |
|
esprehn
2013/07/04 20:17:50
btw, you don't need to call pseudoElement(BACKDROP
falken
2013/07/05 02:16:14
Done.
|
| } |
| PseudoElement* Element::pseudoElement(PseudoId pseudoId) const |