Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Unified Diff: Source/core/dom/Element.h

Issue 17654008: Implement the ::backdrop pseudo-element for modal <dialog>. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: fix failing tests Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/dom/Element.h
diff --git a/Source/core/dom/Element.h b/Source/core/dom/Element.h
index 521ff69970b4afc6536379ca8139f1a627f4ca24..36ed8770d386b244d295295024442febd4332af0 100644
--- a/Source/core/dom/Element.h
+++ b/Source/core/dom/Element.h
@@ -573,7 +573,7 @@ public:
virtual bool isDisabledFormControl() const { return false; }
bool isInert() const;
- virtual bool shouldBeReparentedUnderRenderView(const RenderStyle*) const { return isInTopLayer(); }
+ virtual bool shouldBeReparentedUnderRenderView(const RenderStyle*) const { return pseudoId() == BACKDROP || isInTopLayer(); }
Julien - ping for review 2013/06/27 22:49:00 Won't this break everything by making backdrop a s
falken 2013/06/28 08:06:52 Hm, I was thinking of ::backdrop as a standalone t
virtual bool childShouldCreateRenderer(const NodeRenderingContext&) const;
bool hasPendingResources() const;

Powered by Google App Engine
This is Rietveld 408576698