Source/core/dom/Element.h - Issue 17654008: Implement the ::backdrop pseudo-element for modal <dialog>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/Element.h

Issue 17654008: Implement the ::backdrop pseudo-element for modal <dialog>. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: review comments Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/dom/Element.h

diff --git a/Source/core/dom/Element.h b/Source/core/dom/Element.h

index 521ff69970b4afc6536379ca8139f1a627f4ca24..36ed8770d386b244d295295024442febd4332af0 100644

--- a/Source/core/dom/Element.h

+++ b/Source/core/dom/Element.h

@@ -573,7 +573,7 @@ public:

virtual bool isDisabledFormControl() const { return false; }

bool isInert() const;

- virtual bool shouldBeReparentedUnderRenderView(const RenderStyle*) const { return isInTopLayer(); }

+ virtual bool shouldBeReparentedUnderRenderView(const RenderStyle*) const { return pseudoId() == BACKDROP || isInTopLayer(); }

virtual bool childShouldCreateRenderer(const NodeRenderingContext&) const;

bool hasPendingResources() const;