Implement the ::backdrop pseudo-element for modal <dialog>.

Source/core/css/resolver/StyleResolver.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com)
  * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com)
  * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved.
  * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org>
  * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org>
  * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
  * Copyright (c) 2011, Code Aurora Forum. All rights reserved.
  * Copyright (C) Research In Motion Limited 2011. All rights reserved.
@@ skipping 1211 matching lines @@
 PassRefPtr<RenderStyle> StyleResolver::pseudoStyleForElement(Element* e, const PseudoStyleRequest& pseudoStyleRequest, RenderStyle* parentStyle)
 {
     ASSERT(parentStyle);
     if (!e)
         return 0;
 
     StyleResolverState& state = m_state;
 
     state.initForStyleResolve(document(), e, parentStyle);
 
-    if (m_state.parentStyle()) {
+    if (pseudoStyleRequest.pseudoId != BACKDROP && m_state.parentStyle()) { // The spec disallows inheritance for ::backdrop.

[esprehn, 2013/07/03 23:44:29]

Lets add a method on PseudoStyleRequest which is allowsInheritance() const {
return parentStyle() && pseudoId != BACKDROP; }

btw I don't think this is enough, adjustRenderStyle below is going to muck up
your style based on your parentStyle even though you're being reparented into
the render view. This is a general issue, I think you need to fix
adjustRenderStyle to be smarter for top layer. Lets fix that in a different
patch though, it's only a few cases where you can tell.

[falken, 2013/07/04 08:20:12]

Done. That looks a lot better.
OK thanks, will take a look.

         state.setStyle(RenderStyle::create());
         state.style()->inheritFrom(m_state.parentStyle());
     } else {
         state.setStyle(defaultStyleForElement());
         state.setParentStyle(RenderStyle::clone(state.style()));
     }
 
     // Since we don't use pseudo-elements in any of our quirk/print user agent rules, don't waste time walking
     // those rules.
 
@@ skipping 153 matching lines @@
         ASSERT_NOT_REACHED();
         return NONE;
     }
     ASSERT_NOT_REACHED();
     return BLOCK;
 }
 
 // CSS requires text-decoration to be reset at each DOM element for tables,
 // inline blocks, inline tables, run-ins, shadow DOM crossings, floating elements,
 // and absolute or relatively positioned elements.
-static bool doesNotInheritTextDecoration(RenderStyle* style, Element* e)
+static bool doesNotInheritTextDecoration(const RenderStyle* style, const Element* e)
 {
     return style->display() == TABLE || style->display() == INLINE_TABLE || style->display() == RUN_IN
         || style->display() == INLINE_BLOCK || style->display() == INLINE_BOX || isAtShadowBoundary(e)
         || style->isFloating() || style->hasOutOfFlowPosition();
 }
 
+static bool isRenderedInTopLayer(const RenderStyle* style, const Element* e) {
+    return (e && e->isInTopLayer()) || (style && style->styleType() == BACKDROP);

[esprehn, 2013/07/03 23:44:29]

This looks bad, the PseudoElement for ::backdrop should have isInTopLayer as
true. By design PseudoElements should act like real elements with the same bits
set on them.

[falken, 2013/07/04 08:20:12]

Even with the new patch, I have to keep this helper since we enter
adjustRenderStyle as part of createPseudoElementIfNeeded, so the element is
null.

+}
+
 static bool isDisplayFlexibleBox(EDisplay display)
 {
     return display == FLEX || display == INLINE_FLEX;
 }
 
 static bool isDisplayGridBox(EDisplay display)
 {
     return display == GRID || display == INLINE_GRID;
 }
 
@@ skipping 48 matching lines @@
 
         // FIXME: We shouldn't be overriding start/-webkit-auto like this. Do it in html.css instead.
         // Table headers with a text-align of -webkit-auto will change the text-align to center.
         if (e && e->hasTagName(thTag) && style->textAlign() == TASTART)
             style->setTextAlign(CENTER);
 
         if (e && e->hasTagName(legendTag))
             style->setDisplay(BLOCK);
 
         // Per the spec, position 'static' and 'relative' in the top layer compute to 'absolute'.
-        if (e && e->isInTopLayer() && (style->position() == StaticPosition || style->position() == RelativePosition))
+        if (isRenderedInTopLayer(style, e) && (style->position() == StaticPosition || style->position() == RelativePosition))
             style->setPosition(AbsolutePosition);
 
         // Absolute/fixed positioned elements, floating elements and the document element need block-like outside display.
         if (style->hasOutOfFlowPosition() || style->isFloating() || (e && e->document()->documentElement() == e))
             style->setDisplay(equivalentBlockDisplay(style->display(), style->isFloating(), !document()->inQuirksMode()));
 
         // FIXME: Don't support this mutation for pseudo styles like first-letter or first-line, since it's not completely
         // clear how that should work.
         if (style->display() == INLINE && style->styleType() == NOPSEUDO && style->writingMode() != parentStyle->writingMode())
             style->setDisplay(INLINE_BLOCK);
@@ skipping 35 matching lines @@
     if (style->hasAutoZIndex() && ((e && e->document()->documentElement() == e)
         || style->opacity() < 1.0f
         || style->hasTransformRelatedProperty()
         || style->hasMask()
         || style->clipPath()
         || style->boxReflect()
         || style->hasFilter()
         || style->hasBlendMode()
         || style->position() == StickyPosition
         || (style->position() == FixedPosition && e && e->document()->page() && e->document()->page()->settings()->fixedPositionCreatesStackingContext())
-        || (e && e->isInTopLayer())
+        || isRenderedInTopLayer(style, e)
         ))
         style->setZIndex(0);
 
     // Textarea considers overflow visible as auto.
     if (e && e->hasTagName(textareaTag)) {
         style->setOverflowX(style->overflowX() == OVISIBLE ? OAUTO : style->overflowX());
         style->setOverflowY(style->overflowY() == OVISIBLE ? OAUTO : style->overflowY());
     }
 
     // For now, <marquee> requires an overflow clip to work properly.
@@ skipping 1889 matching lines @@
     info.addMember(m_state, "state");
 
     // FIXME: move this to a place where it would be called only once?
     info.addMember(CSSDefaultStyleSheets::defaultStyle, "defaultStyle");
     info.addMember(CSSDefaultStyleSheets::defaultQuirksStyle, "defaultQuirksStyle");
     info.addMember(CSSDefaultStyleSheets::defaultPrintStyle, "defaultPrintStyle");
     info.addMember(CSSDefaultStyleSheets::defaultViewSourceStyle, "defaultViewSourceStyle");
 }
 
 } // namespace WebCore