Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 17654003: [telemetry] Add Google Cloud Storage utilities. (Closed)

Created:
7 years, 6 months ago by dtu
Modified:
7 years, 5 months ago
Reviewers:
nduca, tonyg
CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org
Visibility:
Public.

Description

[telemetry] Add Google Cloud Storage utilities. Add oauth2client to telemetry/third_party for OAuth2 authentication. BUG=223667 TEST=Ran a simple test locally, but unit tests will be hard without Internet.

Patch Set 1 #

Patch Set 2 : Minor cleanup. #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+5010 lines, -19 lines) Patch
M tools/telemetry/docs/telemetry.core.chrome.inspector_network.html View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/docs/telemetry.core.platform.profiler.perf_profiler.html View 1 chunk +6 lines, -5 lines 0 comments Download
M tools/telemetry/docs/telemetry.page.html View 1 chunk +7 lines, -6 lines 0 comments Download
A tools/telemetry/docs/telemetry.page.cloud_storage.html View 1 1 chunk +152 lines, -0 lines 0 comments Download
M tools/telemetry/docs/telemetry.page.page_test_runner.html View 1 chunk +1 line, -8 lines 0 comments Download
A tools/telemetry/telemetry/page/cloud_storage.py View 1 1 chunk +109 lines, -0 lines 4 comments Download
A tools/telemetry/third_party/oauth2client/MANIFEST.in View 1 chunk +1 line, -0 lines 0 comments Download
A tools/telemetry/third_party/oauth2client/PKG-INFO View 1 chunk +16 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/oauth2client/README View 1 chunk +23 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/oauth2client/README.chromium View 1 chunk +13 lines, -0 lines 2 comments Download
A tools/telemetry/third_party/oauth2client/oauth2client.egg-info/PKG-INFO View 1 chunk +16 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/oauth2client/oauth2client.egg-info/SOURCES.txt View 1 chunk +23 lines, -0 lines 0 comments Download
A + tools/telemetry/third_party/oauth2client/oauth2client.egg-info/dependency_links.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A tools/telemetry/third_party/oauth2client/oauth2client.egg-info/requires.txt View 1 chunk +2 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/oauth2client/oauth2client.egg-info/top_level.txt View 1 chunk +1 line, -0 lines 0 comments Download
A tools/telemetry/third_party/oauth2client/oauth2client/__init__.py View 1 chunk +11 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/oauth2client/oauth2client/anyjson.py View 1 chunk +32 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/oauth2client/oauth2client/appengine.py View 1 chunk +896 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/oauth2client/oauth2client/client.py View 1 chunk +1364 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/oauth2client/oauth2client/clientsecrets.py View 1 chunk +153 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/oauth2client/oauth2client/crypt.py View 1 chunk +377 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/oauth2client/oauth2client/django_orm.py View 1 chunk +134 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/oauth2client/oauth2client/file.py View 1 chunk +124 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/oauth2client/oauth2client/gce.py View 1 chunk +90 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/oauth2client/oauth2client/keyring_storage.py View 1 chunk +109 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/oauth2client/oauth2client/locked_file.py View 1 chunk +361 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/oauth2client/oauth2client/multistore_file.py View 1 chunk +409 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/oauth2client/oauth2client/tools.py View 1 chunk +205 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/oauth2client/oauth2client/util.py View 1 chunk +192 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/oauth2client/oauth2client/xsrfutil.py View 1 chunk +113 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/oauth2client/setup.cfg View 1 chunk +5 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/oauth2client/setup.py View 1 chunk +65 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
dtu
7 years, 6 months ago (2013-06-25 03:02:09 UTC) #1
tonyg
https://codereview.chromium.org/17654003/diff/3001/tools/telemetry/telemetry/page/cloud_storage.py File tools/telemetry/telemetry/page/cloud_storage.py (right): https://codereview.chromium.org/17654003/diff/3001/tools/telemetry/telemetry/page/cloud_storage.py#newcode26 tools/telemetry/telemetry/page/cloud_storage.py:26: GSUTIL_CLIENT_NOTSOSECRET = 'p3RlpR10xMFh9ZXBS/ZNLYUu' What does NOTSOSECRET mean? Is it ...
7 years, 6 months ago (2013-06-25 23:14:37 UTC) #2
dtu
https://codereview.chromium.org/17654003/diff/3001/tools/telemetry/telemetry/page/cloud_storage.py File tools/telemetry/telemetry/page/cloud_storage.py (right): https://codereview.chromium.org/17654003/diff/3001/tools/telemetry/telemetry/page/cloud_storage.py#newcode26 tools/telemetry/telemetry/page/cloud_storage.py:26: GSUTIL_CLIENT_NOTSOSECRET = 'p3RlpR10xMFh9ZXBS/ZNLYUu' On 2013/06/25 23:14:37, tonyg wrote: > ...
7 years, 6 months ago (2013-06-26 00:04:46 UTC) #3
nduca
> > depot_tools has oauth2_plugin. Is there any way we can reuse that? > > ...
7 years, 6 months ago (2013-06-26 04:57:42 UTC) #4
dtu
7 years, 6 months ago (2013-06-26 23:19:11 UTC) #5 
On 2013/06/26 04:57:42, nduca wrote:
> > > depot_tools has oauth2_plugin. Is there any way we can reuse that?
> > 
> > Yes, if we're willing to bootstrap depot_tools. Both ways work. Shrug, nduca
> > suggested doing it this way instead on the bug, comment #13
> 
> My recollection is that bootstrapping from depot tools has its own soup of
> complexities and that it is simpler for us to duplicate rather than resolve
> those complexities. This isn't our core feature so we felt that the cost of
> doing it right and using depot tools outweighed the role of the feature.

Hrm, that might only be true if we want to use gclient. If we're just using
gsutil, it could be a lot easier.

Powered by Google App Engine
This is Rietveld 408576698