Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(737)

Issue 1765383004: PPC: [wasm] Int64Lowering of I64Shl. (Closed)

Created:
4 years, 9 months ago by MTBrandyberry
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [wasm] Int64Lowering of I64Shl. Port ddc626e1cf365261fa38cd3b91cbaf8b5e0444b9 Original commit message: I64Shl is lowered to a new turbofan operator, WasmWord64Shl. The new operator takes 3 inputs, the low-word input, the high-word input, and the shift, and produces 2 output, the low-word output and the high-word output. R=ahaas@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= Committed: https://crrev.com/e36eba88f5c986c6ce8b277082a64d44ef624914 Cr-Commit-Position: refs/heads/master@{#34588}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -0 lines) Patch
M src/compiler/ppc/code-generator-ppc.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M src/compiler/ppc/instruction-codes-ppc.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/ppc/instruction-scheduler-ppc.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/ppc/instruction-selector-ppc.cc View 1 chunk +22 lines, -0 lines 0 comments Download
M src/ppc/macro-assembler-ppc.h View 1 chunk +7 lines, -0 lines 0 comments Download
M src/ppc/macro-assembler-ppc.cc View 1 chunk +46 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
MTBrandyberry
PTAL
4 years, 9 months ago (2016-03-08 05:00:25 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1765383004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1765383004/1
4 years, 9 months ago (2016-03-08 05:02:04 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-08 05:18:47 UTC) #5
ahaas
lgtm
4 years, 9 months ago (2016-03-08 09:02:17 UTC) #6
michael_dawson
On 2016/03/08 09:02:17, ahaas wrote: > lgtm lgtm
4 years, 9 months ago (2016-03-08 12:34:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1765383004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1765383004/1
4 years, 9 months ago (2016-03-08 14:47:40 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-08 14:49:42 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-08 14:50:15 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e36eba88f5c986c6ce8b277082a64d44ef624914
Cr-Commit-Position: refs/heads/master@{#34588}

Powered by Google App Engine
This is Rietveld 408576698