Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1765333002:
Add proguard definitions to prevent stripping of methods (Closed)
|
Created:
4 years, 9 months ago by sgurun-gerrit only Modified:
4 years, 9 months ago CC:
chromium-reviews, android-webview-reviews_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd proguard definitions to prevent stripping of methods
Newly added WebviewChromium methods getHandler and findFocus
were being stripped by proguard. Explicitly keep them in .jar.
Committed: https://crrev.com/4e0e6528676be9ee35c31286c19f7bb9d4c7e957
Cr-Commit-Position: refs/heads/master@{#379922}
Patch Set 1 #
Messages
Total messages: 19 (10 generated)
Description was changed from ========== Add proguard definitions to prevent stripping of methods Newly added WebviewChromium methods getHandler and findFocus were being stripped by proguard. Explicitly keep them in .jar. ========== to ========== Add proguard definitions to prevent stripping of methods Newly added WebviewChromium methods getHandler and findFocus were being stripped by proguard. Explicitly keep them in .jar. ==========
sgurun@chromium.org changed reviewers: + aelias@chromium.org
On 2016/03/05 04:15:10, sgurun wrote: > mailto:sgurun@chromium.org changed reviewers: > + mailto:aelias@chromium.org PTAL, thanks
sgurun@chromium.org changed reviewers: + hush@chromium.org
lgtm FTR: https://codereview.chromium.org/1669873003/ is the original CL that added these 2 methods
The CQ bit was checked by sgurun@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1765333002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1765333002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by sgurun@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1765333002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1765333002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by sgurun@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1765333002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1765333002/1
Message was sent while issue was closed.
Description was changed from ========== Add proguard definitions to prevent stripping of methods Newly added WebviewChromium methods getHandler and findFocus were being stripped by proguard. Explicitly keep them in .jar. ========== to ========== Add proguard definitions to prevent stripping of methods Newly added WebviewChromium methods getHandler and findFocus were being stripped by proguard. Explicitly keep them in .jar. ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Add proguard definitions to prevent stripping of methods Newly added WebviewChromium methods getHandler and findFocus were being stripped by proguard. Explicitly keep them in .jar. ========== to ========== Add proguard definitions to prevent stripping of methods Newly added WebviewChromium methods getHandler and findFocus were being stripped by proguard. Explicitly keep them in .jar. Committed: https://crrev.com/4e0e6528676be9ee35c31286c19f7bb9d4c7e957 Cr-Commit-Position: refs/heads/master@{#379922} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/4e0e6528676be9ee35c31286c19f7bb9d4c7e957 Cr-Commit-Position: refs/heads/master@{#379922} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
