Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 17653005: Merge StreamContext into ChromeBlobStorageContext (Closed)

Created:
7 years, 6 months ago by tyoshino (SeeGerritForStatus)
Modified:
7 years, 2 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, kinuko+watch, jam, tzik+watch_chromium.org
Visibility:
Public.

Description

Merge StreamContext into ChromeBlobStorageContext We're trying to have Blob and Stream share the same code as much as possible. They're both storage classes with backing store but with different semantics. There we see much duplication of code between these context classes. BUG=169957

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -159 lines) Patch
M content/browser/fileapi/chrome_blob_storage_context.h View 3 chunks +10 lines, -4 lines 0 comments Download
M content/browser/fileapi/chrome_blob_storage_context.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M content/browser/loader/resource_dispatcher_host_impl.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M content/browser/resource_context_impl.h View 1 2 2 chunks +0 lines, -4 lines 0 comments Download
M content/browser/resource_context_impl.cc View 1 2 4 chunks +0 lines, -14 lines 0 comments Download
M content/browser/storage_partition_impl_map.cc View 1 2 3 4 5 6 7 7 chunks +11 lines, -13 lines 0 comments Download
D content/browser/streams/stream_context.h View 1 2 1 chunk +0 lines, -60 lines 0 comments Download
D content/browser/streams/stream_context.cc View 1 2 1 chunk +0 lines, -57 lines 0 comments Download
M content/content_browser.gypi View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
kinuko
(Drive-by) this certainly reduces some duplicated code, but I'm not very sure merging things at ...
7 years, 6 months ago (2013-06-25 14:45:15 UTC) #1
tyoshino (SeeGerritForStatus)
Thanks for the comment. The argument that we shouldn't proceed merging everything at this point ...
7 years, 6 months ago (2013-06-26 04:19:12 UTC) #2
tyoshino (SeeGerritForStatus)
7 years, 2 months ago (2013-10-02 04:42:27 UTC) #3
Abandoned

Powered by Google App Engine
This is Rietveld 408576698