Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(771)

Unified Diff: components/metrics/BUILD.gn

Issue 1765293002: Add support for Blimp engine metrics reporting in development. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rename #define. Replace HEADLESS with BLIMP to clarify use. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/browser_process_impl.cc ('k') | components/metrics/metrics_log.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/metrics/BUILD.gn
diff --git a/components/metrics/BUILD.gn b/components/metrics/BUILD.gn
index 6130dd5ea3ef5c2fe431768a5f86ac84c4536256..c49e4a350cf4ef70c12347bc2cb4ac7ece1591f9 100644
--- a/components/metrics/BUILD.gn
+++ b/components/metrics/BUILD.gn
@@ -2,6 +2,11 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
+declare_args() {
+ # Overrides os name in uma metrics log to "Blimp".
+ metrics_use_blimp = false
+}
+
# GYP version: components/metrics.gypi:metrics
source_set("metrics") {
sources = [
@@ -347,5 +352,14 @@ source_set("unit_tests") {
if (is_chromeos) {
deps += [ ":leak_detector_unit_tests" ]
}
+
+ # These are only used by the blimp team, which has entirely migrated to gn,
+ # so this logic is not replicated in the gyp file.
+ if (metrics_use_blimp) {
+ defines = [
+ "OVERRIDE_OS_NAME_TO_BLIMP",
+ "ENABLE_REPORTING_BLIMP",
+ ]
+ }
}
# TODO(GYP): metrics_chromeos
« no previous file with comments | « chrome/browser/browser_process_impl.cc ('k') | components/metrics/metrics_log.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698