Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(510)

Side by Side Diff: components/metrics/BUILD.gn

Issue 1765293002: Add support for Blimp engine metrics reporting in development. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update arg location so check only occurs if was declared. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 declare_args() {
6 # Overrides os name in uma metrics log to "Blimp".
7 metrics_use_blimp = false
8 }
9
5 # GYP version: components/metrics.gypi:metrics 10 # GYP version: components/metrics.gypi:metrics
6 source_set("metrics") { 11 source_set("metrics") {
7 sources = [ 12 sources = [
8 "call_stack_profile_metrics_provider.cc", 13 "call_stack_profile_metrics_provider.cc",
9 "call_stack_profile_metrics_provider.h", 14 "call_stack_profile_metrics_provider.h",
10 "clean_exit_beacon.cc", 15 "clean_exit_beacon.cc",
11 "clean_exit_beacon.h", 16 "clean_exit_beacon.h",
12 "client_info.cc", 17 "client_info.cc",
13 "client_info.h", 18 "client_info.h",
14 "cloned_install_detector.cc", 19 "cloned_install_detector.cc",
(...skipping 325 matching lines...) Expand 10 before | Expand all | Expand 10 after
340 ] 345 ]
341 346
342 if (is_linux) { 347 if (is_linux) {
343 sources += [ "serialization/serialization_utils_unittest.cc" ] 348 sources += [ "serialization/serialization_utils_unittest.cc" ]
344 deps += [ ":serialization" ] 349 deps += [ ":serialization" ]
345 } 350 }
346 351
347 if (is_chromeos) { 352 if (is_chromeos) {
348 deps += [ ":leak_detector_unit_tests" ] 353 deps += [ ":leak_detector_unit_tests" ]
349 } 354 }
355
356 if (metrics_use_blimp) {
357 defines = [
358 "OVERRIDE_OS_NAME_TO_BLIMP",
359 "ENABLE_REPORTING_HEADLESS",
360 ]
361 }
Alexei Svitkine (slow) 2016/03/07 20:38:25 Do these same changes need to be done at the gyp l
Jess 2016/03/07 21:09:21 Blimp builds are entirely GN based and, for our us
Alexei Svitkine (slow) 2016/03/07 21:17:44 Ah OK. Fine to keep it just in the GN file. Please
Jess 2016/03/07 22:28:08 Done.
350 } 362 }
351 # TODO(GYP): metrics_chromeos 363 # TODO(GYP): metrics_chromeos
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698