Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Issue 1765273002: kiosk: Add kiosk launch type UMA (Closed)

Created:
4 years, 9 months ago by xiyuan
Modified:
4 years, 9 months ago
Reviewers:
Ilya Sherman, jennyz
CC:
chromium-reviews, asvitkine+watch_chromium.org, dzhioev+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

kiosk: Add kiosk launch type UMA BUG=592022 Committed: https://crrev.com/7e33a712878360d6439612e36f33e59acb17a94e Cr-Commit-Position: refs/heads/master@{#379883}

Patch Set 1 #

Total comments: 6

Patch Set 2 : for #1 comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -6 lines) Patch
M chrome/browser/chromeos/login/app_launch_controller.cc View 1 5 chunks +34 lines, -6 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 chunks +16 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
xiyuan
4 years, 9 months ago (2016-03-05 00:05:47 UTC) #2
Ilya Sherman
metrics lgtm % nits: https://codereview.chromium.org/1765273002/diff/1/chrome/browser/chromeos/login/app_launch_controller.cc File chrome/browser/chromeos/login/app_launch_controller.cc (right): https://codereview.chromium.org/1765273002/diff/1/chrome/browser/chromeos/login/app_launch_controller.cc#newcode15 chrome/browser/chromeos/login/app_launch_controller.cc:15: #include "base/metrics/histogram.h" nit: Please include ...
4 years, 9 months ago (2016-03-05 00:30:26 UTC) #3
xiyuan
https://codereview.chromium.org/1765273002/diff/1/chrome/browser/chromeos/login/app_launch_controller.cc File chrome/browser/chromeos/login/app_launch_controller.cc (right): https://codereview.chromium.org/1765273002/diff/1/chrome/browser/chromeos/login/app_launch_controller.cc#newcode15 chrome/browser/chromeos/login/app_launch_controller.cc:15: #include "base/metrics/histogram.h" On 2016/03/05 00:30:26, Ilya Sherman wrote: > ...
4 years, 9 months ago (2016-03-07 15:41:22 UTC) #4
jennyz
lgtm
4 years, 9 months ago (2016-03-08 17:34:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1765273002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1765273002/20001
4 years, 9 months ago (2016-03-08 18:00:13 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-08 19:26:47 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-08 19:27:52 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7e33a712878360d6439612e36f33e59acb17a94e
Cr-Commit-Position: refs/heads/master@{#379883}

Powered by Google App Engine
This is Rietveld 408576698