Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issue 1765243002: Remove Mojo bindings environment. (Closed)

Created:
4 years, 9 months ago by yzshen1
Modified:
4 years, 9 months ago
CC:
chromium-reviews, rjkroege, mlamouri+watch-content_chromium.org, feature-media-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, glider+watch_chromium.org, cbentzel+watch_chromium.org, blink-reviews, jam, extensions-reviews_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, timvolodine, mkwst+moarreviews-renderer_chromium.org, chromium-apps-reviews_chromium.org, darin (slow to review), ben+mojo_chromium.org, kinuko+watch, bruening+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -2654 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M build/all.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M build/gn_migration.gypi View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/BUILD.gn View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/libgtk2ui/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_common.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/BUILD.gn View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M components/arc/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
M components/arc/arc_bridge_service_unittest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M components/contextual_search/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/dom_distiller.gypi View 2 chunks +0 lines, -2 lines 0 comments Download
M components/dom_distiller/content/browser/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/dom_distiller/content/renderer/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/filesystem/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/leveldb/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/mus/public/cpp/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
M components/mus/ws/BUILD.gn View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M components/resource_provider/BUILD.gn View 3 chunks +0 lines, -3 lines 0 comments Download
M content/app/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/child/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/common/BUILD.gn View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M content/content_app.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M content/content_child.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M content/content_common.gypi View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M content/content_common_mojo_bindings.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M content/content_renderer.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M content/content_tests.gypi View 4 chunks +0 lines, -4 lines 0 comments Download
M content/renderer/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/test/BUILD.gn View 3 chunks +0 lines, -3 lines 0 comments Download
M device/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M device/battery/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M device/battery/battery.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M device/device_tests.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M device/serial/data_sink_unittest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M device/serial/data_source_unittest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M device/vibration/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M device/vibration/vibration.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M extensions/extensions_tests.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/shell/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/shell/app_shell.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M ipc/mojo/BUILD.gn View 1 2 3 4 5 3 chunks +0 lines, -4 lines 0 comments Download
M ipc/mojo/ipc_message_pipe_reader.h View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M ipc/mojo/ipc_mojo.gyp View 1 2 3 4 5 3 chunks +0 lines, -3 lines 0 comments Download
M media/mojo/common/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M media/mojo/interfaces/mojo_bindings.gyp View 2 chunks +0 lines, -2 lines 0 comments Download
M media/mojo/services/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M mojo/BUILD.gn View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M mojo/android/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M mojo/android/javatests/mojo_test_case.cc View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/common/BUILD.gn View 3 chunks +0 lines, -4 lines 0 comments Download
M mojo/converters/blink/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/converters/geometry/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/converters/ime/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/converters/input_events/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/converters/surfaces/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/converters/surfaces/tests/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/converters/transform/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/edk/js/test/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
M mojo/edk/js/tests/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M mojo/edk/system/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M mojo/edk/test/BUILD.gn View 1 2 3 4 5 2 chunks +0 lines, -8 lines 0 comments Download
D mojo/environment/BUILD.gn View 1 chunk +0 lines, -59 lines 0 comments Download
D mojo/environment/default_async_waiter_impl.h View 1 chunk +0 lines, -19 lines 0 comments Download
D mojo/environment/default_async_waiter_impl.cc View 1 chunk +0 lines, -51 lines 0 comments Download
D mojo/environment/default_logger_impl.h View 1 chunk +0 lines, -19 lines 0 comments Download
D mojo/environment/default_logger_impl.cc View 1 chunk +0 lines, -76 lines 0 comments Download
D mojo/environment/default_run_loop_impl.h View 1 chunk +0 lines, -19 lines 0 comments Download
D mojo/environment/default_run_loop_impl.cc View 1 chunk +0 lines, -27 lines 0 comments Download
D mojo/environment/default_task_tracker_impl.h View 1 chunk +0 lines, -19 lines 0 comments Download
D mojo/environment/default_task_tracker_impl.cc View 1 chunk +0 lines, -35 lines 0 comments Download
D mojo/environment/environment.cc View 1 chunk +0 lines, -55 lines 0 comments Download
D mojo/environment/mojo_environment_impl_export.h View 1 chunk +0 lines, -32 lines 0 comments Download
M mojo/gles2/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/mojo_base.gyp View 1 2 3 4 5 5 chunks +0 lines, -57 lines 0 comments Download
M mojo/mojo_edk_tests.gyp View 1 2 3 4 5 7 chunks +0 lines, -37 lines 0 comments Download
M mojo/mojo_public.gyp View 1 2 3 4 5 1 chunk +0 lines, -27 lines 0 comments Download
D mojo/mojo_public_environment_unittests.isolate View 1 chunk +0 lines, -44 lines 0 comments Download
M mojo/mojo_shell.gyp View 1 2 3 4 5 2 chunks +0 lines, -2 lines 0 comments Download
M mojo/public/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M mojo/public/c/README.md View 1 chunk +2 lines, -9 lines 0 comments Download
D mojo/public/c/environment/BUILD.gn View 1 chunk +0 lines, -14 lines 0 comments Download
D mojo/public/c/environment/async_waiter.h View 1 chunk +0 lines, -30 lines 0 comments Download
D mojo/public/c/environment/logger.h View 1 chunk +0 lines, -61 lines 0 comments Download
M mojo/public/c/gles2/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/public/c/system/tests/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
M mojo/public/c/system/tests/core_unittest_pure_c.c View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/public/cpp/README.md View 2 chunks +2 lines, -25 lines 0 comments Download
M mojo/public/cpp/bindings/tests/BUILD.gn View 1 2 3 4 5 2 chunks +0 lines, -2 lines 0 comments Download
D mojo/public/cpp/environment/BUILD.gn View 1 chunk +0 lines, -47 lines 0 comments Download
D mojo/public/cpp/environment/async_waiter.h View 1 chunk +0 lines, -40 lines 0 comments Download
D mojo/public/cpp/environment/environment.h View 1 chunk +0 lines, -53 lines 0 comments Download
D mojo/public/cpp/environment/lib/async_waiter.cc View 1 chunk +0 lines, -34 lines 0 comments Download
D mojo/public/cpp/environment/lib/default_async_waiter.h View 1 chunk +0 lines, -18 lines 0 comments Download
D mojo/public/cpp/environment/lib/default_async_waiter.cc View 1 chunk +0 lines, -85 lines 0 comments Download
D mojo/public/cpp/environment/lib/default_logger.h View 1 chunk +0 lines, -18 lines 0 comments Download
D mojo/public/cpp/environment/lib/default_logger.cc View 1 chunk +0 lines, -78 lines 0 comments Download
D mojo/public/cpp/environment/lib/default_task_tracker.h View 1 chunk +0 lines, -19 lines 0 comments Download
D mojo/public/cpp/environment/lib/default_task_tracker.cc View 1 chunk +0 lines, -40 lines 0 comments Download
D mojo/public/cpp/environment/lib/environment.cc View 1 chunk +0 lines, -93 lines 0 comments Download
D mojo/public/cpp/environment/lib/logging.cc View 1 chunk +0 lines, -47 lines 0 comments Download
D mojo/public/cpp/environment/lib/scoped_task_tracking.h View 1 chunk +0 lines, -34 lines 0 comments Download
D mojo/public/cpp/environment/lib/scoped_task_tracking.cc View 1 chunk +0 lines, -37 lines 0 comments Download
D mojo/public/cpp/environment/logging.h View 1 chunk +0 lines, -97 lines 0 comments Download
D mojo/public/cpp/environment/task_tracker.h View 1 chunk +0 lines, -30 lines 0 comments Download
D mojo/public/cpp/environment/tests/BUILD.gn View 1 chunk +0 lines, -24 lines 0 comments Download
D mojo/public/cpp/environment/tests/async_wait_unittest.cc View 1 chunk +0 lines, -114 lines 0 comments Download
D mojo/public/cpp/environment/tests/async_waiter_unittest.cc View 1 chunk +0 lines, -107 lines 0 comments Download
D mojo/public/cpp/environment/tests/logger_unittest.cc View 1 chunk +0 lines, -89 lines 0 comments Download
D mojo/public/cpp/environment/tests/logging_unittest.cc View 1 chunk +0 lines, -522 lines 0 comments Download
M mojo/public/cpp/system/tests/BUILD.gn View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M mojo/public/cpp/utility/tests/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/public/interfaces/bindings/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M mojo/public/interfaces/bindings/tests/BUILD.gn View 8 chunks +0 lines, -16 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/module.cc.tmpl View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/public/tools/bindings/mojom.gni View 2 chunks +0 lines, -8 lines 0 comments Download
M mojo/services/network/public/cpp/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/shell/public/cpp/BUILD.gn View 1 2 3 4 5 2 chunks +0 lines, -2 lines 0 comments Download
M mojo/shell/public/cpp/lib/application_test_base.cc View 1 2 3 4 5 5 chunks +13 lines, -8 lines 0 comments Download
M net/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M net/net.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M testing/buildbot/chromium.fyi.json View 9 chunks +0 lines, -45 lines 0 comments Download
M testing/buildbot/chromium.linux.json View 4 chunks +0 lines, -24 lines 0 comments Download
M testing/buildbot/chromium.mac.json View 5 chunks +0 lines, -25 lines 0 comments Download
M testing/buildbot/chromium.memory.fyi.json View 7 chunks +0 lines, -23 lines 0 comments Download
M testing/buildbot/chromium.win.json View 5 chunks +0 lines, -27 lines 0 comments Download
M testing/buildbot/chromium_trybot.json View 1 chunk +0 lines, -1 line 0 comments Download
M testing/buildbot/client.v8.fyi.json View 1 chunk +0 lines, -1 line 0 comments Download
M testing/buildbot/gn_isolate_map.pyl View 1 chunk +0 lines, -4 lines 0 comments Download
M testing/buildbot/tryserver.v8.json View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/blink_platform.gyp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/blink_platform_tests.gyp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M tools/battor_agent/battor_agent.gyp View 2 chunks +0 lines, -2 lines 0 comments Download
M tools/valgrind/chrome_tests.py View 2 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 42 (20 generated)
yzshen1
Hi, Ben. Would you please take a look? Thanks!
4 years, 9 months ago (2016-03-05 08:09:22 UTC) #2
Ben Goodger (Google)
lgtm
4 years, 9 months ago (2016-03-05 15:26:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1765243002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1765243002/80001
4 years, 9 months ago (2016-03-06 03:19:40 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/126046)
4 years, 9 months ago (2016-03-06 03:33:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1765243002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1765243002/80001
4 years, 9 months ago (2016-03-06 07:02:32 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/178525)
4 years, 9 months ago (2016-03-06 08:14:03 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1765243002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1765243002/80001
4 years, 9 months ago (2016-03-06 19:11:00 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/184734)
4 years, 9 months ago (2016-03-06 21:31:39 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1765243002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1765243002/80001
4 years, 9 months ago (2016-03-07 17:25:39 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/185063)
4 years, 9 months ago (2016-03-07 20:06:00 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1765243002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1765243002/80001
4 years, 9 months ago (2016-03-07 20:12:18 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/178934)
4 years, 9 months ago (2016-03-07 22:02:53 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1765243002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1765243002/80001
4 years, 9 months ago (2016-03-08 00:52:35 UTC) #25
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/185390) win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, ...
4 years, 9 months ago (2016-03-08 00:59:58 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1765243002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1765243002/100001
4 years, 9 months ago (2016-03-08 08:20:03 UTC) #30
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/185600)
4 years, 9 months ago (2016-03-08 10:20:36 UTC) #32
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1765243002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1765243002/100001
4 years, 9 months ago (2016-03-08 15:23:06 UTC) #34
commit-bot: I haz the power
Patchset 6 (id:??) landed as https://crrev.com/c24416c14fe16743e6cc6edafc1a28e0a1d51473 Cr-Commit-Position: refs/heads/master@{#379839}
4 years, 9 months ago (2016-03-08 16:26:04 UTC) #36
yzshen1
Committed patchset #6 (id:100001) manually as c24416c14fe16743e6cc6edafc1a28e0a1d51473 (presubmit successful).
4 years, 9 months ago (2016-03-08 16:26:50 UTC) #38
Lei Zhang
There's still a few bots trying to run the mojo_public_env test. Can you follow up ...
4 years, 9 months ago (2016-03-09 09:16:10 UTC) #40
yzshen1
On 2016/03/09 09:16:10, Lei Zhang (OOO) wrote: > There's still a few bots trying to ...
4 years, 9 months ago (2016-03-09 16:50:24 UTC) #41
yzshen1
4 years, 9 months ago (2016-03-09 16:50:25 UTC) #42
Message was sent while issue was closed.
On 2016/03/09 09:16:10, Lei Zhang (OOO) wrote:
> There's still a few bots trying to run the mojo_public_env test. Can you
follow
> up and remove those too?
> 
>
https://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Unit%20(D...
>
https://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Unit%20(D...
>
https://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Unit%20%2...

I have removed mojo_public_env from build/ yesterday:
https://codereview.chromium.org/1773473004/

Maybe I need troopers's help to restart those bots in order for them to pick up
the changes?
Thanks for the info!

Powered by Google App Engine
This is Rietveld 408576698