Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1213)

Issue 176523003: Don't clobber VS runtime DLLs (Closed)

Created:
6 years, 10 months ago by scottmg
Modified:
6 years, 10 months ago
Reviewers:
Nico
CC:
chromium-reviews, kjellander-cc_chromium.org, cmp-cc_chromium.org, ilevy-cc_chromium.org, stip+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build@master
Visibility:
Public.

Description

Don't clobber VS runtime DLLs These are put there during generation; seems like clobber should happen before that. TBR=thakis@chromium.org BUG=309197 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=252842

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M scripts/slave/compile.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
scottmg
6 years, 10 months ago (2014-02-23 05:21:41 UTC) #1
scottmg
The CQ bit was checked by scottmg@chromium.org
6 years, 10 months ago (2014-02-23 05:21:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/176523003/1
6 years, 10 months ago (2014-02-23 05:21:57 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-23 05:23:13 UTC) #4
commit-bot: I haz the power
Presubmit check for 176523003-1 failed and returned exit status 1. Running presubmit commit checks ...
6 years, 10 months ago (2014-02-23 05:23:14 UTC) #5
scottmg
The CQ bit was checked by scottmg@chromium.org
6 years, 10 months ago (2014-02-23 05:23:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/176523003/1
6 years, 10 months ago (2014-02-23 05:23:32 UTC) #7
commit-bot: I haz the power
6 years, 10 months ago (2014-02-23 05:25:25 UTC) #8
Message was sent while issue was closed.
Change committed as 252842

Powered by Google App Engine
This is Rietveld 408576698