Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Unified Diff: third_party/WebKit/Source/devtools/protocol.json

Issue 1765153002: Update DevTools Tracing.Start to accept trace config as a parameter (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix link error Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/protocol.json
diff --git a/third_party/WebKit/Source/devtools/protocol.json b/third_party/WebKit/Source/devtools/protocol.json
index 8ca06b8440503febf231b190c57ba0883171813b..4cf5fe40c7d4a2faae9e10552602a43bb832a025 100644
--- a/third_party/WebKit/Source/devtools/protocol.json
+++ b/third_party/WebKit/Source/devtools/protocol.json
@@ -4824,16 +4824,56 @@
},
{
"domain": "Tracing",
+ "types": [
+ {
+ "id": "RecordMode",
+ "type": "string",
+ "enum": ["recordUntilFull", "recordContinuously", "recordAsMuchAsPossible", "echoToConsole"],
+ "description": "The option that determines how the trace buffer stores data."
+ },
+ {
+ "id": "MemoryDumpTrigger",
+ "type": "object",
+ "properties": [
+ { "name": "mode", "type": "string", "optional": false, "description": "" },
+ { "name": "periodicIntervalMs", "type": "integer", "optional": false, "description": "" }
+ ],
+ "description": "The configurations that trigger memory dump."
+ },
+ {
+ "id": "MemoryDumpConfig",
+ "type": "object",
+ "properties": [
+ { "name": "triggers", "type": "array", "items": { "$ref": "Tracing.MemoryDumpTrigger" }, "optional": false, "description": "The configurations that trigger memory dump." }
+ ],
+ "description": "The configuration for memory dump. Used only when \"memory-infra\" category is enabled."
+ },
+ {
+ "id": "TraceConfig",
+ "type": "object",
+ "properties": [
+ { "name": "recordMode", "$ref": "Tracing.RecordMode", "optional": true, "description": "The option that determines how the trace buffer stores data." },
caseq 2016/03/12 00:13:33 nit: here and below, drop "The option that" from d
Zhen Wang 2016/03/13 18:17:06 Done.
+ { "name": "enableSampling", "type": "boolean", "optional": true, "description": "The option that enables sampling." },
caseq 2016/03/12 00:13:33 "description": "Turn on JavaScript stack sampling"
Zhen Wang 2016/03/13 18:17:06 Done.
+ { "name": "enableSystrace", "type": "boolean", "optional": true, "description": "The option that enables system tracing." },
+ { "name": "enableArgumentFilter", "type": "boolean", "optional": true, "description": "The option that enables argument filter." },
+ { "name": "includedCategories", "type": "array", "items": { "type": "string" }, "optional": true, "description": "The category filters that are included." },
+ { "name": "excludedCategories", "type": "array", "items": { "type": "string" }, "optional": true, "description": "The category filters that are excluded." },
+ { "name": "syntheticDelays", "type": "array", "items": { "type": "string" }, "optional": true, "description": "The configuration to synthesize the delays in tracing." },
+ { "name": "memoryDumpConfig", "$ref": "Tracing.MemoryDumpConfig", "optional": true, "description": "The configuration for memory dump. Used only when \"memory-infra\" category is enabled." }
caseq 2016/03/12 00:33:33 "$ref": "MemoryDumpConfig", remove "Tracing." pref
Zhen Wang 2016/03/13 18:17:06 Done.
+ ]
+ }
+ ],
"commands": [
{
"name": "start",
"async": true,
"description": "Start trace events collection.",
"parameters": [
- { "name": "categories", "type": "string", "optional": true, "description": "Category/tag filter" },
- { "name": "options", "type": "string", "optional": true, "description": "Tracing options" },
+ { "name": "categories", "type": "string", "optional": true, "deprecated": true, "description": "Category/tag filter" },
+ { "name": "options", "type": "string", "optional": true, "deprecated": true, "description": "Tracing options" },
{ "name": "bufferUsageReportingInterval", "type": "number", "optional": true, "description": "If set, the agent will issue bufferUsage events at this interval, specified in milliseconds" },
- { "name": "transferMode", "type": "string", "enum": ["ReportEvents", "ReturnAsStream"], "optional": true, "description": "Whether to report trace events as series of dataCollected events or to save trace to a stream (defaults to <code>ReportEvents</code>)." }
+ { "name": "transferMode", "type": "string", "enum": ["ReportEvents", "ReturnAsStream"], "optional": true, "description": "Whether to report trace events as series of dataCollected events or to save trace to a stream (defaults to <code>ReportEvents</code>)." },
+ { "name": "traceConfig", "$ref": "Tracing.TraceConfig", "optional": true, "description": "" }
caseq 2016/03/12 00:33:33 ditto.
Zhen Wang 2016/03/13 18:17:06 Done.
],
"handlers": ["browser", "renderer"]
},

Powered by Google App Engine
This is Rietveld 408576698