third_party/WebKit/Source/core/inspector/InspectorTracingAgent.cpp - Issue 1765153002: Update DevTools Tracing.Start to accept trace config as a parameter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorTracingAgent.cpp

Issue 1765153002: Update DevTools Tracing.Start to accept trace config as a parameter (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add test Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/devtools/protocol/tracing_handler_unittest.cc ('K') | « third_party/WebKit/Source/core/inspector/InspectorTracingAgent.h ('k') | third_party/WebKit/Source/devtools/protocol.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/InspectorTracingAgent.cpp

diff --git a/third_party/WebKit/Source/core/inspector/InspectorTracingAgent.cpp b/third_party/WebKit/Source/core/inspector/InspectorTracingAgent.cpp

index 6d6a25cef00561a7bb4cec5c445b66f2edf666f4..7784a36cecb29409f2ae8b647059ffc9e7d181bc 100644

--- a/third_party/WebKit/Source/core/inspector/InspectorTracingAgent.cpp

+++ b/third_party/WebKit/Source/core/inspector/InspectorTracingAgent.cpp

@@ -48,9 +48,13 @@ void InspectorTracingAgent::start(ErrorString*,

const Maybe<String>& options,

const Maybe<double>& bufferUsageReportingInterval,

const Maybe<String>& transferMode,

+ const Maybe<protocol::Tracing::TraceConfig>& config,

PassOwnPtr<StartCallback> callback)

{

ASSERT(sessionId().isEmpty());

+ // Trace config should not be used on the renderer side.

+ ASSERT(!config.isJust());

m_state->setString(TracingAgentState::sessionId, IdentifiersFactory::createIdentifier());

m_client->enableTracing(categories.fromMaybe(String()));

emitMetadataEvents();