Update DevTools Tracing.Start to accept trace config as a parameter

third_party/WebKit/Source/devtools/protocol.json

Index: third_party/WebKit/Source/devtools/protocol.json
diff --git a/third_party/WebKit/Source/devtools/protocol.json b/third_party/WebKit/Source/devtools/protocol.json
index 8ca06b8440503febf231b190c57ba0883171813b..069189f03fe87a8a041bcff60af6ac8bef1b9a1f 100644
--- a/third_party/WebKit/Source/devtools/protocol.json
+++ b/third_party/WebKit/Source/devtools/protocol.json
@@ -4824,16 +4824,62 @@
     },
     {
         "domain": "Tracing",
+        "types": [
+            {
+                "id": "RecordMode",
+                "type": "string",
+                "enum": ["recordUntilFull", "recordContinuously", "recordAsMuchAsPossible", "echoToConsole"],
+                "description": "Option that determines how the trace buffer stores data."
+            },
+            {
+                "id": "MemoryDumpTriggerMode",
+                "type": "string",
+                "enum": ["light", "detailed"],
+                "description": "Option that determines how to trigger memory dumps."

[petrcermak, 2016/03/15 12:15:07]

I think that the id should be "MemoryDumpLevelOfDetail" and the description
should be "Level of detail of a memory dump."

Primiano: What do you think about the naming here? The field in the trace config
is indeed called "mode", but it's then stored as a "level_of_detail"
(https://code.google.com/p/chromium/codesearch#chromium/src/base/trace_event/t...).
Do we want to go with my above proposal for id ("MemoryDumpLevelOfDetail"), or
should we match the public trace config and keep "MemoryDumpTriggerMode"? What
about the description? "Level of detail of a memory dump." or a generic "Memory
dump trigger mode."?

[Primiano Tucci (use gerrit), 2016/03/15 15:36:52]

I think we should reflect the trace_config as much as possible [1]
MDTMode honestly looks good to me here.

[1]
https://chromium.googlesource.com/chromium/src/+/master/components/tracing/do...

[Zhen Wang, 2016/03/15 16:53:55]

Acknowledged.

Updated the description.

+            },
+            {
+                "id": "MemoryDumpTrigger",
+                "type": "object",
+                "properties": [
+                    { "name": "mode", "$ref": "MemoryDumpTriggerMode", "optional": false, "description": "Option that determines how to trigger memory dumps." },

[petrcermak, 2016/03/15 12:15:08]

s/Option that .../Level of detail of the triggered memory dumps./

[Zhen Wang, 2016/03/15 16:53:55]

Done.

+                    { "name": "periodicIntervalMs", "type": "integer", "optional": false, "description": "Length of the periodic intervals to trigger memory dumps in milliseconds." }

[petrcermak, 2016/03/15 12:15:08]

nit: s/intervals to trigger memory dumps/intervals between the triggered memory
dumps/

[Zhen Wang, 2016/03/15 16:53:55]

Done.

+                ],
+                "description": "Configurations that trigger memory dump."

[petrcermak, 2016/03/15 12:15:08]

s/Configurations .../Memory dump trigger configuration./

[Zhen Wang, 2016/03/15 16:53:55]

Done.

+            },
+            {
+                "id": "MemoryDumpConfig",
+                "type": "object",
+                "properties": [
+                    { "name": "triggers", "type": "array", "items": { "$ref": "MemoryDumpTrigger" }, "optional": false, "description": "Configurations that trigger memory dump." }

[petrcermak, 2016/03/15 12:15:08]

s/Configurations .../Memory dump trigger configurations./

[Zhen Wang, 2016/03/15 16:53:55]

Done.

+                ],
+                "description": "Configuration for memory dump. Used only when \"memory-infra\" category is enabled."

[petrcermak, 2016/03/15 12:15:08]

nit: s/memory dump/memory dump triggers/

[Zhen Wang, 2016/03/15 16:53:55]

Done.

+            },
+            {
+                "id": "TraceConfig",
+                "type": "object",
+                "properties": [
+                    { "name": "recordMode", "$ref": "RecordMode", "optional": true, "description": "Controls how the trace buffer stores data." },
+                    { "name": "enableSampling", "type": "boolean", "optional": true, "description": "Turns on JavaScript stack sampling." },
+                    { "name": "enableSystrace", "type": "boolean", "optional": true, "description": "Turns on system tracing." },
+                    { "name": "enableArgumentFilter", "type": "boolean", "optional": true, "description": "Turns on argument filter." },
+                    { "name": "includedCategories", "type": "array", "items": { "type": "string" }, "optional": true, "description": "Category filters that are included." },

[petrcermak, 2016/03/15 12:15:08]

"Included category filters."

[Zhen Wang, 2016/03/15 16:53:55]

Done.

+                    { "name": "excludedCategories", "type": "array", "items": { "type": "string" }, "optional": true, "description": "Category filters that are excluded." },

[petrcermak, 2016/03/15 12:15:08]

"Excluded category filters."

[Zhen Wang, 2016/03/15 16:53:55]

Done.

+                    { "name": "syntheticDelays", "type": "array", "items": { "type": "string" }, "optional": true, "description": "Configuration to synthesize the delays in tracing." },
+                    { "name": "memoryDumpConfig", "$ref": "MemoryDumpConfig", "optional": true, "description": "Configuration for memory dump. Used only when \"memory-infra\" category is enabled." }

[petrcermak, 2016/03/15 12:15:08]

nit: s/memory dump/memory dump triggers/

[Zhen Wang, 2016/03/15 16:53:55]

Done.

+                ]
+            }
+        ],
         "commands": [
             {
                 "name": "start",
                 "async": true,
                 "description": "Start trace events collection.",
                 "parameters": [
-                    { "name": "categories", "type": "string", "optional": true, "description": "Category/tag filter" },
-                    { "name": "options", "type": "string", "optional": true, "description": "Tracing options" },
+                    { "name": "categories", "type": "string", "optional": true, "deprecated": true, "description": "Category/tag filter" },
+                    { "name": "options", "type": "string", "optional": true, "deprecated": true, "description": "Tracing options" },
                     { "name": "bufferUsageReportingInterval", "type": "number", "optional": true, "description": "If set, the agent will issue bufferUsage events at this interval, specified in milliseconds" },
-                    { "name": "transferMode", "type": "string", "enum": ["ReportEvents", "ReturnAsStream"], "optional": true, "description": "Whether to report trace events as series of dataCollected events or to save trace to a stream (defaults to <code>ReportEvents</code>)." }
+                    { "name": "transferMode", "type": "string", "enum": ["ReportEvents", "ReturnAsStream"], "optional": true, "description": "Whether to report trace events as series of dataCollected events or to save trace to a stream (defaults to <code>ReportEvents</code>)." },
+                    { "name": "traceConfig", "$ref": "TraceConfig", "optional": true, "description": "" }
                 ],
                 "handlers": ["browser", "renderer"]
             },