Chromium Code Reviews| Index: third_party/WebKit/Source/core/inspector/InspectorTracingAgent.cpp |
| diff --git a/third_party/WebKit/Source/core/inspector/InspectorTracingAgent.cpp b/third_party/WebKit/Source/core/inspector/InspectorTracingAgent.cpp |
| index 6d6a25cef00561a7bb4cec5c445b66f2edf666f4..577b9ef6dbc789394cb5129199e0c92b2d3604c0 100644 |
| --- a/third_party/WebKit/Source/core/inspector/InspectorTracingAgent.cpp |
| +++ b/third_party/WebKit/Source/core/inspector/InspectorTracingAgent.cpp |
| @@ -43,14 +43,21 @@ void InspectorTracingAgent::restore() |
| { |
| emitMetadataEvents(); |
| } |
| -void InspectorTracingAgent::start(ErrorString*, |
| +void InspectorTracingAgent::start(ErrorString* errorString, |
| const Maybe<String>& categories, |
| const Maybe<String>& options, |
| const Maybe<double>& bufferUsageReportingInterval, |
| const Maybe<String>& transferMode, |
| + const Maybe<protocol::Tracing::TraceConfig>& config, |
| PassOwnPtr<StartCallback> callback) |
| { |
| ASSERT(sessionId().isEmpty()); |
| + if (config.isJust()) { |
| + *errorString = |
| + "Using trace config on render targets is not yet supported."; |
|
petrcermak
2016/03/14 18:05:09
super nit: s/yet supported/supported yet/
petrcermak
2016/03/14 18:05:09
Also, shouldn't it be "renderer"?
Zhen Wang
2016/03/14 21:41:45
done
|
| + return; |
| + } |
| + |
| m_state->setString(TracingAgentState::sessionId, IdentifiersFactory::createIdentifier()); |
| m_client->enableTracing(categories.fromMaybe(String())); |
| emitMetadataEvents(); |