Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2357)

Unified Diff: base/trace_event/trace_config.h

Issue 1765153002: Update DevTools Tracing.Start to accept trace config as a parameter (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/trace_event/trace_config.cc » ('j') | base/trace_event/trace_config.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/trace_event/trace_config.h
diff --git a/base/trace_event/trace_config.h b/base/trace_event/trace_config.h
index 81b7d515133dd0c3c71f461316ced768e6fd9618..d1b11e0af3e4a73eaa214d43c29e60f94ec634e4 100644
--- a/base/trace_event/trace_config.h
+++ b/base/trace_event/trace_config.h
@@ -49,6 +49,15 @@ class BASE_EXPORT TraceConfig {
typedef std::vector<MemoryDumpTriggerConfig> MemoryDumpConfig;
+ // Convert from DevTools style to tracing style. That is:
+ // 1. Convert dict key style: abcDefGhi => abc_def_ghi.
+ // For example: includedCategories => included_categories
+ // 2. Convert trace record mode style: abcDefGhi => abc-def-ghi.
+ // For example: recordUntilFull => record-until-full
+ static scoped_ptr<base::DictionaryValue> DevToolsToTracingStyle(
caseq 2016/03/05 02:25:24 I think it would be better out of base -- doing th
Primiano Tucci (use gerrit) 2016/03/06 01:24:37 +1. Base should not know anything about devtools.
+ const scoped_ptr<base::DictionaryValue>& devtools_style);
+ static std::string DevToolsToTracingStyle(const std::string& devtools_style);
+
TraceConfig();
// Create TraceConfig object from category filter and trace options strings.
« no previous file with comments | « no previous file | base/trace_event/trace_config.cc » ('j') | base/trace_event/trace_config.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698