Update DevTools Tracing.Start to accept trace config as a parameter

base/trace_event/trace_config_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
 
+#include "base/json/json_reader.h"
+#include "base/json/json_writer.h"
 #include "base/macros.h"
 #include "base/trace_event/memory_dump_manager.h"
 #include "base/trace_event/trace_config.h"
 #include "base/trace_event/trace_config_memory_test_util.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace base {
 namespace trace_event {
 
 namespace {
 
 const char kDefaultTraceConfigString[] =
   "{"
     "\"enable_argument_filter\":false,"
     "\"enable_sampling\":false,"
     "\"enable_systrace\":false,"
     "\"excluded_categories\":[\"*Debug\",\"*Test\"],"
     "\"record_mode\":\"record-until-full\""
   "}";
+
+const char kCustomTraceConfigString[] =
+  "{"
+    "\"enable_argument_filter\":true,"
+    "\"enable_sampling\":true,"
+    "\"enable_systrace\":true,"
+    "\"excluded_categories\":[\"excluded\",\"exc_pattern*\"],"
+    "\"included_categories\":[\"included\","
+                            "\"inc_pattern*\","
+                            "\"disabled-by-default-cc\","
+                            "\"disabled-by-default-memory-infra\"],"
+    "\"memory_dump_config\":{"
+      "\"triggers\":["
+        "{\"mode\":\"light\",\"periodic_interval_ms\":50},"
+        "{\"mode\":\"detailed\",\"periodic_interval_ms\":1000}"
+      "]"
+    "},"
+    "\"record_mode\":\"record-continuously\","
+    "\"synthetic_delays\":[\"test.Delay1;16\",\"test.Delay2;32\"]"
+  "}";
+
+const char kCustomTraceConfigStringDevtoolsStyle[] =
+  "{"
+    "\"enableArgumentFilter\":true,"
+    "\"enableSampling\":true,"
+    "\"enableSystrace\":true,"
+    "\"excludedCategories\":[\"excluded\",\"exc_pattern*\"],"
+    "\"includedCategories\":[\"included\","
+                            "\"inc_pattern*\","
+                            "\"disabled-by-default-cc\","
+                            "\"disabled-by-default-memory-infra\"],"
+    "\"memoryDumpConfig\":{"
+      "\"triggers\":["
+        "{\"mode\":\"light\",\"periodicIntervalMs\":50},"
+        "{\"mode\":\"detailed\",\"periodicIntervalMs\":1000}"
+      "]"
+    "},"
+    "\"recordMode\":\"recordContinuously\","
+    "\"synthetic_delays\":[\"test.Delay1;16\",\"test.Delay2;32\"]"
+  "}";
+
 }  // namespace
 
 TEST(TraceConfigTest, TraceConfigFromValidLegacyFormat) {
   // From trace options strings
   TraceConfig config("", "record-until-full");
   EXPECT_EQ(RECORD_UNTIL_FULL, config.GetTraceRecordMode());
   EXPECT_FALSE(config.IsSamplingEnabled());
   EXPECT_FALSE(config.IsSystraceEnabled());
   EXPECT_FALSE(config.IsArgumentFilterEnabled());
   EXPECT_STREQ("record-until-full", config.ToTraceOptionsString().c_str());
@@ skipping 487 matching lines @@
   EXPECT_EQ(0u, tc.memory_dump_config_.size());
 }
 
 TEST(TraceConfigTest, LegacyStringToMemoryDumpConfig) {
   TraceConfig tc(MemoryDumpManager::kTraceCategory, "");
   EXPECT_TRUE(tc.IsCategoryGroupEnabled(MemoryDumpManager::kTraceCategory));
   EXPECT_NE(std::string::npos, tc.ToString().find("memory_dump_config"));
   EXPECT_EQ(2u, tc.memory_dump_config_.size());
 }
 
+TEST(TraceConfigTest, DevToolsToTracingStyleForDict) {
+  scoped_ptr<Value> value = base::JSONReader::Read(
+      kCustomTraceConfigStringDevtoolsStyle);
+  scoped_ptr<base::DictionaryValue> devtools_style_dict(
+      static_cast<base::DictionaryValue*>(value.release()));
+  scoped_ptr<base::DictionaryValue> tracing_style_dict =
+      TraceConfig::DevToolsToTracingStyle(devtools_style_dict);
+
+  std::string tracing_style_str;
+  base::JSONWriter::Write(*tracing_style_dict, &tracing_style_str);
+  EXPECT_STREQ(kCustomTraceConfigString, tracing_style_str.c_str());
+}
+
+TEST(TraceConfigTest, DevToolsToTracingStyleForString) {
+  std::string tracing_style = TraceConfig::DevToolsToTracingStyle(
+      kCustomTraceConfigStringDevtoolsStyle);
+
+  EXPECT_STREQ(kCustomTraceConfigString, tracing_style.c_str());
+}
+
 }  // namespace trace_event
 }  // namespace base