Chromium Code Reviews Chromium Code Reviews
Issue 1765143002:
[Media Router] Add UMA histograms tracking component extension version/wakeups (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: tools/metrics/histograms/histograms.xml |
| diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml |
| index 5497178166c85bfd7ebd6775c83614bd3dc6ca93..df3786e9b00e32f591b1e97fed6efd956b8d1fa0 100644 |
| --- a/tools/metrics/histograms/histograms.xml |
| +++ b/tools/metrics/histograms/histograms.xml |
| @@ -20984,6 +20984,14 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries. |
| <summary>Location the user clicked to open the Media Router dialog.</summary> |
| </histogram> |
| +<histogram name="MediaRouter.Provider.Version" enum="MediaRouteProviderVersion"> |
| + <owner>mfoltz@chromium.org</owner> |
| + <summary> |
| + Records how the major version of the Media Router component extension |
| + compares to the major version of the browser. |
| + </summary> |
| +</histogram> |
| + |
| <histogram name="MediaRouter.Provider.WakeReason" |
| enum="MediaRouteProviderWakeReason"> |
| <owner>mfoltz@chromium.org</owner> |
| @@ -20992,6 +21000,13 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries. |
| </summary> |
| </histogram> |
| +<histogram name="MediaRouter.Provider.Wakeup" enum="MediaRouteProviderWakeup"> |
| + <owner>mfoltz@chromium.org</owner> |
| + <summary> |
| + Records the outcome of waking the Media Router component's event page. |
| + </summary> |
| +</histogram> |
| + |
| <histogram name="MediaRouter.Route.CreationOutcome" |
| units="MediaRouterCreateRouteOutcome"> |
| <owner>apacible@chromium.org</owner> |
| @@ -74288,6 +74303,13 @@ To add a new entry, add it with any value and run test to compute valid value. |
| <int value="1" label="Has errors"/> |
| </enum> |
| +<enum name="MediaRouteProviderVersion" type="int"> |
| + <int value="0" label="Unknown"/> |
| + <int value="1" label="SameVersionAsChrome"/> |
| + <int value="2" label="OneVersionBehindChrome"/> |
| + <int value="3" label="MultipleVersionsBehindChrome"/> |
|
Ilya Sherman
2016/03/18 03:51:51
nit: It's fine to use spaces in labels if you like
Wez
2016/03/18 18:35:43
FWIW I like the space-less version; slightly easie
mark a. foltz
2016/03/18 20:11:01
I think I am going to leave them as camel case.
|
| +</enum> |
| + |
| <enum name="MediaRouteProviderWakeReason" type="int"> |
| <int value="0" label="CreateRoute"/> |
| <int value="1" label="JoinRoute"/> |
| @@ -74306,6 +74328,12 @@ To add a new entry, add it with any value and run test to compute valid value. |
| <int value="14" label="ConnectRouteByRouteId"/> |
| </enum> |
| +<enum name="MediaRouteProviderWakeup" type="int"> |
| + <int value="0" label="Success"/> |
| + <int value="1" label="ErrorUnknown"/> |
| + <int value="2" label="ErrorTooManyRetries"/> |
| +</enum> |
| + |
| <enum name="MediaRouterCreateRouteOutcome" type="int"> |
| <int value="0" label="Success"/> |
| <int value="1" label="Failure No Route"/> |
