Fix up GrAuditTrail to allow arbitrary reordering

Fix up GrAuditTrail to allow arbitrary reordering

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1765123002

Committed: https://skia.googlesource.com/skia/+/b0666ad3a9e99ce1a6e6d9ea69ff9f1ddbe74594

[joshua.litt, 2016-03-04 19:25:00]

Description was changed from

==========
Fix up GrAuditTrail to allow arbitrary reordering

BUG=skia:
==========

to

==========
Fix up GrAuditTrail to allow arbitrary reordering

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[joshualitt, 2016-03-04 19:26:43]

joshualitt@google.com changed reviewers:
+ ethannicholas@google.com, jcgregorio@google.com, joshualitt@google.com

[joshualitt, 2016-03-04 19:26:43]

I'm sure this is a bit slower than the old algorithm when we batch, but I doubt
its too significant.  More importantly, it allows arbitrary reordering of
batches.

[joshualitt, 2016-03-04 21:05:50]

Description was changed from

==========
Fix up GrAuditTrail to allow arbitrary reordering

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Fix up GrAuditTrail to allow arbitrary reordering

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[joshualitt, 2016-03-04 21:05:50]

joshualitt@google.com changed reviewers:
+ bsalomon@google.com

[joshualitt, 2016-03-04 21:06:04]

adding Brian

[bsalomon, 2016-03-07 16:46:34]

seems ok to me

https://codereview.chromium.org/1765123002/diff/1/include/private/GrAuditTrail.h
File include/private/GrAuditTrail.h (right):

https://codereview.chromium.org/1765123002/diff/1/include/private/GrAuditTrai...
include/private/GrAuditTrail.h:89: void batchingResultCombined(const GrBatch*
combineWith, const GrBatch* batch);
Maybe name the param combinedWith? or consumerBatch and consumedBatch?

[joshualitt, 2016-03-07 18:05:40]

On 2016/03/07 16:46:34, bsalomon wrote:
> seems ok to me
> 
>
https://codereview.chromium.org/1765123002/diff/1/include/private/GrAuditTrail.h
> File include/private/GrAuditTrail.h (right):
> 
>
https://codereview.chromium.org/1765123002/diff/1/include/private/GrAuditTrai...
> include/private/GrAuditTrail.h:89: void batchingResultCombined(const GrBatch*
> combineWith, const GrBatch* batch);
> Maybe name the param combinedWith? or consumerBatch and consumedBatch?

name changed, Ethan any thoughts?  I'd like to land this today.

[joshualitt, 2016-03-07 21:41:40]

On 2016/03/07 18:05:40, joshualitt wrote:
> On 2016/03/07 16:46:34, bsalomon wrote:
> > seems ok to me
> > 
> >
>
https://codereview.chromium.org/1765123002/diff/1/include/private/GrAuditTrail.h
> > File include/private/GrAuditTrail.h (right):
> > 
> >
>
https://codereview.chromium.org/1765123002/diff/1/include/private/GrAuditTrai...
> > include/private/GrAuditTrail.h:89: void batchingResultCombined(const
GrBatch*
> > combineWith, const GrBatch* batch);
> > Maybe name the param combinedWith? or consumerBatch and consumedBatch?
> 
> name changed, Ethan any thoughts?  I'd like to land this today.

okay some fixes, I rebased and think this is working correctly

[ethannicholas, 2016-03-07 21:44:03]

lgtm

[joshualitt, 2016-03-08 13:29:45]

The CQ bit was checked by joshualitt@google.com

[commit-bot: I haz the power, 2016-03-08 13:29:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1765123002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1765123002/60001

[commit-bot: I haz the power, 2016-03-08 13:31:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-08 13:31:22]

Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia
(JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)

[joshualitt, 2016-03-08 18:30:54]

The CQ bit was checked by joshualitt@google.com

[joshualitt, 2016-03-08 18:30:54]

The patchset sent to the CQ was uploaded after l-g-t-m from
ethannicholas@google.com
Link to the patchset: https://codereview.chromium.org/1765123002/#ps80001
(title: "fix up audit trail")

[commit-bot: I haz the power, 2016-03-08 18:31:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1765123002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1765123002/80001

[commit-bot: I haz the power, 2016-03-08 18:43:44]

Description was changed from

==========
Fix up GrAuditTrail to allow arbitrary reordering

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Fix up GrAuditTrail to allow arbitrary reordering

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/b0666ad3a9e99ce1a6e6d9ea69ff9f1ddbe74594
==========

[commit-bot: I haz the power, 2016-03-08 18:43:45]

Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/b0666ad3a9e99ce1a6e6d9ea69ff9f1ddbe74594