Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Issue 1765073003: Revert of roll gyp ed163ce233:61259d585c (Closed)

Created:
4 years, 9 months ago by Nico
Modified:
4 years, 9 months ago
Reviewers:
scottmg
CC:
chromium-reviews, justincohen
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of roll gyp ed163ce233:61259d585c (patchset #3 id:40001 of https://codereview.chromium.org/1766033002/ ) Reason for revert: Same failure again. Original issue's description: > roll gyp ed163ce233:61259d585c > > 61259d5 ninja/win: Use qualified paths for precompiled headers. > 1950f67 Xcode-ninja: Add excluded files to the project sources_for_indexing.xcodeproj > d84fed2 Fix tests with Xcode 7. > 0cd47bf Make login.keychain and 'Provisioning Profiles' symlinks. > > BUG=none > R=scottmg@chromium.org > TBR=scottmg > > Committed: https://crrev.com/f90f632aa4e1fc9750ea41a9f6ebdee1240aa678 > Cr-Commit-Position: refs/heads/master@{#379373} > > Committed: https://chromium.googlesource.com/chromium/src/+/bcc0a572a0388ec650894017b0848509ee61e79a TBR=scottmg@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=none Committed: https://crrev.com/cf63f1fb41bc7dd6b4b965325bf704e17b98ea07 Cr-Commit-Position: refs/heads/master@{#379426}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M build/win_precompile.gypi View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/build/win/precompile.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
Nico
Created Revert of roll gyp ed163ce233:61259d585c
4 years, 9 months ago (2016-03-05 01:20:26 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1765073003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1765073003/1
4 years, 9 months ago (2016-03-05 01:20:58 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-05 01:21:36 UTC) #3
commit-bot: I haz the power
4 years, 9 months ago (2016-03-05 01:25:07 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cf63f1fb41bc7dd6b4b965325bf704e17b98ea07
Cr-Commit-Position: refs/heads/master@{#379426}

Powered by Google App Engine
This is Rietveld 408576698