Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1313)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1765013002: Handle case of deleted mojom file in Dart bindings presubmit script (Closed)

Created:
4 years, 9 months ago by Cutch
Modified:
4 years, 9 months ago
Reviewers:
jamesr
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, darin (slow to review), gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+mojopublicwatch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Handle case of deleted mojom file in Dart bindings presubmit script R=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/f93f0c0b916efaf049364d8f8a2c99ddb86a0a3f

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -1 line) Patch
M mojo/dart/tools/presubmit/check_mojom_dart.py View 3 chunks +20 lines, -1 line 0 comments Download

Messages

Total messages: 9 (6 generated)
Cutch
4 years, 9 months ago (2016-03-04 15:25:06 UTC) #5
jamesr
lgtm wish we had tests for this stuff
4 years, 9 months ago (2016-03-04 18:39:42 UTC) #7
Cutch
4 years, 9 months ago (2016-03-04 20:22:56 UTC) #9
Message was sent while issue was closed. 
Committed patchset #1 (id:40001) manually as
f93f0c0b916efaf049364d8f8a2c99ddb86a0a3f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698