Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 1764963002: [compiler] Reduce number of entry points into compiler API. (Closed)

Created:
4 years, 9 months ago by Michael Starzinger
Modified:
4 years, 9 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[compiler] Reduce number of entry points into compiler API. This removes the entry point to the compiler API which allows requesting lazily compiled full-codegen code. The aim is to eventually allow the decisions of which baseline compiler should be used (e.g. Ignition or full-codegen) be centralized within the compiler pipeline. R=bmeurer@chromium.org Committed: https://crrev.com/d0b67b984e84e77f576f3d8b8ca0d7ab1370e296 Cr-Commit-Position: refs/heads/master@{#34489}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -77 lines) Patch
M src/compiler.h View 3 chunks +2 lines, -23 lines 0 comments Download
M src/compiler.cc View 1 7 chunks +50 lines, -8 lines 0 comments Download
M src/runtime/runtime-compiler.cc View 3 chunks +18 lines, -46 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Michael Starzinger
4 years, 9 months ago (2016-03-04 09:51:49 UTC) #2
Benedikt Meurer
LGTM with nit. https://codereview.chromium.org/1764963002/diff/1/src/compiler.cc File src/compiler.cc (right): https://codereview.chromium.org/1764963002/diff/1/src/compiler.cc#newcode1018 src/compiler.cc:1018: static MaybeHandle<Code> GetUnoptimizedCode(Handle<JSFunction> function) { Nit: ...
4 years, 9 months ago (2016-03-04 09:54:07 UTC) #3
Michael Starzinger
Thanks. Addressed comments. Landing. https://codereview.chromium.org/1764963002/diff/1/src/compiler.cc File src/compiler.cc (right): https://codereview.chromium.org/1764963002/diff/1/src/compiler.cc#newcode1018 src/compiler.cc:1018: static MaybeHandle<Code> GetUnoptimizedCode(Handle<JSFunction> function) { ...
4 years, 9 months ago (2016-03-04 10:00:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1764963002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1764963002/20001
4 years, 9 months ago (2016-03-04 10:42:15 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-04 10:44:36 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-04 10:45:47 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d0b67b984e84e77f576f3d8b8ca0d7ab1370e296
Cr-Commit-Position: refs/heads/master@{#34489}

Powered by Google App Engine
This is Rietveld 408576698