Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issue 1764953002: Fix Array.prototype.sort on proxies. (Closed)

Created:
4 years, 9 months ago by neis
Modified:
4 years, 9 months ago
Reviewers:
rossberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix Array.prototype.sort on proxies. BUG=chromium:591699 LOG=n R=rossberg Committed: https://crrev.com/86c955fee0aa15c37a7af1bd7dcb0a8bf5a6d92c Cr-Commit-Position: refs/heads/master@{#34498}

Patch Set 1 #

Patch Set 2 : Test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M src/runtime/runtime-array.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M test/mjsunit/array-sort.js View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
neis
4 years, 9 months ago (2016-03-04 09:09:07 UTC) #1
neis
Hold on, will add a test as well. BTW, the spec for sort is crazy.
4 years, 9 months ago (2016-03-04 09:10:51 UTC) #2
neis
Ok, ptal.
4 years, 9 months ago (2016-03-04 09:20:40 UTC) #3
rossberg
lgtm
4 years, 9 months ago (2016-03-04 14:15:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1764953002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1764953002/20001
4 years, 9 months ago (2016-03-04 14:19:03 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-04 14:42:24 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-04 14:44:03 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/86c955fee0aa15c37a7af1bd7dcb0a8bf5a6d92c
Cr-Commit-Position: refs/heads/master@{#34498}

Powered by Google App Engine
This is Rietveld 408576698