Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issue 1764943003: Make java_binary wrapper scripts deps rather than data_deps. (Closed)

Created:
4 years, 9 months ago by agrieve
Modified:
4 years, 9 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make java_binary wrapper scripts deps rather than data_deps. 1. They don't require the scripts to run (they aren't actually runtime deps of the binary itself. 2. In the case of jmake, where the wrapper script is called during build, the async nature of data_deps means it may not be created in time. 3. This will make gn gen fail if the output location of jmake changes, since it properly lists it as an input now. BUG=none Committed: https://crrev.com/7cca7851502a8cdd54954fce9c6624259c99c76b Cr-Commit-Position: refs/heads/master@{#379556}

Patch Set 1 #

Patch Set 2 : combining CLs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M build/config/android/internal_rules.gni View 1 3 chunks +7 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (6 generated)
agrieve
On 2016/03/04 14:39:09, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:mikecase@chromium.org 🔴
4 years, 9 months ago (2016-03-04 14:39:22 UTC) #3
mikecase (-- gone --)
lgtm
4 years, 9 months ago (2016-03-05 01:38:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1764943003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1764943003/20001
4 years, 9 months ago (2016-03-07 15:29:24 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-07 16:07:30 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-07 16:08:41 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7cca7851502a8cdd54954fce9c6624259c99c76b
Cr-Commit-Position: refs/heads/master@{#379556}

Powered by Google App Engine
This is Rietveld 408576698