Quick fix to ignore a specific error (#25915).

Quick fix to ignore a specific error (#25915).

See: https://github.com/dart-lang/sdk/issues/25915

BUG=
R=scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/1f0a0b5a5c464db06761aa7ec0f8f0ac5081dc33

[pquitslund, 2016-03-03 23:15:34]

pquitslund@google.com changed reviewers:
+ scheglov@google.com

[pquitslund, 2016-03-03 23:15:35]

I have some test updating to do (in cases where this breaks the assumption that
there will be only one fix) but I'm stuck on this one:

ERROR: FixProcessorTest | test_undefinedMethod_parameterType_inTargetUnit
  Test failed: Caught RangeError (index): Invalid value: Not in range 0..37,
inclusive: 76
  dart:core-patch/string_patch.dart 233                                     
_StringBase.codeUnitAt
  package:analysis_server/src/services/correction/util.dart 938:23          
CorrectionUtils.getLineThis
  package:analysis_server/src/services/correction/fix_internal.dart 2201:28 
FixProcessor._addIgnore
  package:analysis_server/src/services/correction/fix_internal.dart 352:5   
FixProcessor.compute.<async>

I can't tell is this is a symptom of how that test is written or whether there's
something amiss in my approach.

Thoughts appreciated!

[scheglov, 2016-03-04 02:35:00]

On 2016/03/03 23:15:35, pquitslund wrote:
> I have some test updating to do (in cases where this breaks the assumption
that
> there will be only one fix) but I'm stuck on this one:
> 
> ERROR: FixProcessorTest | test_undefinedMethod_parameterType_inTargetUnit
>   Test failed: Caught RangeError (index): Invalid value: Not in range 0..37,
> inclusive: 76
>   dart:core-patch/string_patch.dart 233                                     
> _StringBase.codeUnitAt
>   package:analysis_server/src/services/correction/util.dart 938:23          
> CorrectionUtils.getLineThis
>   package:analysis_server/src/services/correction/fix_internal.dart 2201:28 
> FixProcessor._addIgnore
>   package:analysis_server/src/services/correction/fix_internal.dart 352:5   
> FixProcessor.compute.<async>
> 
> I can't tell is this is a symptom of how that test is written or whether
there's
> something amiss in my approach.
> 
> Thoughts appreciated!

The method _addFix_undefinedMethod_create() replaces "utils" and does not set it
back, so any following fix work in a wrong context.
I think we could save "utils" into a local variable and restore on exit from the
method.

Do we really want to ignore all errors, even parse errors?

[pquitslund, 2016-03-04 18:51:10]

On 2016/03/04 02:35:00, scheglov wrote:
> On 2016/03/03 23:15:35, pquitslund wrote:
> > I have some test updating to do (in cases where this breaks the assumption
> that
> > there will be only one fix) but I'm stuck on this one:
> > 
> > ERROR: FixProcessorTest | test_undefinedMethod_parameterType_inTargetUnit
> >   Test failed: Caught RangeError (index): Invalid value: Not in range 0..37,
> > inclusive: 76
> >   dart:core-patch/string_patch.dart 233                                     
> > _StringBase.codeUnitAt
> >   package:analysis_server/src/services/correction/util.dart 938:23          
> > CorrectionUtils.getLineThis
> >   package:analysis_server/src/services/correction/fix_internal.dart 2201:28 
> > FixProcessor._addIgnore
> >   package:analysis_server/src/services/correction/fix_internal.dart 352:5   
> > FixProcessor.compute.<async>
> > 
> > I can't tell is this is a symptom of how that test is written or whether
> there's
> > something amiss in my approach.
> > 
> > Thoughts appreciated!
> 
> The method _addFix_undefinedMethod_create() replaces "utils" and does not set
it
> back, so any following fix work in a wrong context.
> I think we could save "utils" into a local variable and restore on exit from
the
> method.

Addressed by adding my fix first. :)

> 
> Do we really want to ignore all errors, even parse errors?

Great point.  Updated to be more selective.

PTAL!

[scheglov, 2016-03-04 18:55:20]

LGTM

https://codereview.chromium.org/1764853002/diff/20001/pkg/analysis_server/lib...
File pkg/analysis_server/lib/src/services/correction/fix_internal.dart (right):

https://codereview.chromium.org/1764853002/diff/20001/pkg/analysis_server/lib...
pkg/analysis_server/lib/src/services/correction/fix_internal.dart:35: import
'package:analyzer/src/dart/scanner/scanner.dart';
Do we need this import?

https://codereview.chromium.org/1764853002/diff/20001/pkg/analysis_server/tes...
File pkg/analysis_server/test/edit/fixes_test.dart (right):

https://codereview.chromium.org/1764853002/diff/20001/pkg/analysis_server/tes...
pkg/analysis_server/test/edit/fixes_test.dart:41: print(x);
Why do we need this statement?

[pquitslund, 2016-03-04 19:09:39]

Thanks!

https://codereview.chromium.org/1764853002/diff/20001/pkg/analysis_server/lib...
File pkg/analysis_server/lib/src/services/correction/fix_internal.dart (right):

https://codereview.chromium.org/1764853002/diff/20001/pkg/analysis_server/lib...
pkg/analysis_server/lib/src/services/correction/fix_internal.dart:35: import
'package:analyzer/src/dart/scanner/scanner.dart';
On 2016/03/04 18:55:20, scheglov wrote:
> Do we need this import?

We don't!  That was dead.  Removed.

https://codereview.chromium.org/1764853002/diff/20001/pkg/analysis_server/tes...
File pkg/analysis_server/test/edit/fixes_test.dart (right):

https://codereview.chromium.org/1764853002/diff/20001/pkg/analysis_server/tes...
pkg/analysis_server/test/edit/fixes_test.dart:41: print(x);
On 2016/03/04 18:55:20, scheglov wrote:
> Why do we need this statement?

Without it, we get an `unused_local_variable` hint w/ an associated fix which
means errorFixes contains two fixes breaking the expect at line 46.  Seemed
easier to just not see this hint at all.

[pquitslund, 2016-03-04 19:11:11]

Description was changed from

==========
Quick fix to ignore a specific error (#25915).

See: https://github.com/dart-lang/sdk/issues/25915

BUG=
==========

to

==========
Quick fix to ignore a specific error (#25915).

See: https://github.com/dart-lang/sdk/issues/25915

BUG=
R=scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/1f0a0b5a5c464db06761aa7ec0f8f0ac5081dc33
==========

[pquitslund, 2016-03-04 19:11:12]

Committed patchset #2 (id:20001) manually as
1f0a0b5a5c464db06761aa7ec0f8f0ac5081dc33 (presubmit successful).