Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Unified Diff: media/base/android/audio_media_codec_decoder.cc

Issue 1764813002: Catch CodecException in MediaCodecBridge and return MEDIA_CODEC_ERROR (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: dale's comment Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/base/android/audio_media_codec_decoder.cc
diff --git a/media/base/android/audio_media_codec_decoder.cc b/media/base/android/audio_media_codec_decoder.cc
index e148de488cd9e37d6f95ac758c846209da655453..5654e7ca4a0aab3221ad0c82a38cd5e034e0be01 100644
--- a/media/base/android/audio_media_codec_decoder.cc
+++ b/media/base/android/audio_media_codec_decoder.cc
@@ -175,8 +175,9 @@ void AudioMediaCodecDecoder::OnOutputFormatChanged() {
DCHECK(media_codec_bridge_);
int old_sampling_rate = output_sampling_rate_;
- output_sampling_rate_ = media_codec_bridge_->GetOutputSamplingRate();
- if (output_sampling_rate_ != old_sampling_rate)
+ MediaCodecStatus status =
+ media_codec_bridge_->GetOutputSamplingRate(&output_sampling_rate_);
+ if (status != MEDIA_CODEC_OK || output_sampling_rate_ != old_sampling_rate)
ResetTimestampHelper();
}
@@ -201,8 +202,13 @@ void AudioMediaCodecDecoder::Render(int buffer_index,
const bool postpone = (render_mode == kRenderAfterPreroll);
- int64_t head_position =
- audio_codec->PlayOutputBuffer(buffer_index, size, offset, postpone);
+ int64_t head_position;
+ MediaCodecStatus status = audio_codec->PlayOutputBuffer(
+ buffer_index, size, offset, postpone, &head_position);
+ // TODO(timav,watk): This CHECK maintains the behavior of this call before
+ // we started catching CodecException and returning it as MEDIA_CODEC_ERROR.
+ // It needs to be handled some other way. http://crbug.com/585978
+ CHECK_EQ(status, MEDIA_CODEC_OK);
base::TimeTicks current_time = base::TimeTicks::Now();
« no previous file with comments | « media/base/android/audio_decoder_job.cc ('k') | media/base/android/java/src/org/chromium/media/MediaCodecBridge.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698