[wasm] Remove TableSwitch and replace with br_table.

[wasm] Remove TableSwitch and replace with br_table.

R=rossberg@chromium.org,binji@chromium.org,bradnelson@chromium.org
BUG=

Committed: https://crrev.com/bcfa400306bf74e380c7bc38cd5cab498c7d224c
Cr-Commit-Position: refs/heads/master@{#34511}

[titzer, 2016-03-03 18:04:01]

PTAL

[bradn, 2016-03-03 18:08:23]

bradnelson@google.com changed reviewers:
+ bradnelson@google.com

[bradn, 2016-03-03 18:08:23]

lgtm

https://codereview.chromium.org/1764723002/diff/1/src/wasm/ast-decoder.h
File src/wasm/ast-decoder.h (right):

https://codereview.chromium.org/1764723002/diff/1/src/wasm/ast-decoder.h#newc...
src/wasm/ast-decoder.h:150: table_count = decoder->checked_read_u16(pc, 1,
"expected #entries");
I assume these are going to lebs in a later change?

https://codereview.chromium.org/1764723002/diff/1/src/wasm/wasm-macro-gen.h
File src/wasm/wasm-macro-gen.h (right):

https://codereview.chromium.org/1764723002/diff/1/src/wasm/wasm-macro-gen.h#n...
src/wasm/wasm-macro-gen.h:30: #define U32V_1(x) static_cast<byte>(x & MASK_7)
Maybe the leb stuff should go in its own header? (You keep having to move it up
:-)

[binji, 2016-03-04 00:04:17]

lgtm

https://codereview.chromium.org/1764723002/diff/1/test/cctest/wasm/test-run-w...
File test/cctest/wasm/test-run-wasm.cc (right):

https://codereview.chromium.org/1764723002/diff/1/test/cctest/wasm/test-run-w...
test/cctest/wasm/test-run-wasm.cc:22: #define B2(a, b) kExprBlock, 2, a, b
imagine if we could package an argument in the opcode table! </troll>

[rossberg, 2016-03-04 14:25:23]

lgtm

https://codereview.chromium.org/1764723002/diff/1/src/wasm/wasm-macro-gen.h
File src/wasm/wasm-macro-gen.h (right):

https://codereview.chromium.org/1764723002/diff/1/src/wasm/wasm-macro-gen.h#n...
src/wasm/wasm-macro-gen.h:18: #define WASM_MODULE_HEADER U32_LE(kWasmMagic),
U32_LE(kWasmVersion)
Nit: perhaps move the concrete index macros to a separate section; at least put
them after all the generic number macros.

[titzer, 2016-03-04 23:45:04]

The CQ bit was checked by titzer@chromium.org

[titzer, 2016-03-04 23:45:05]

The patchset sent to the CQ was uploaded after l-g-t-m from binji@chromium.org,
rossberg@chromium.org, bradnelson@google.com
Link to the patchset: https://codereview.chromium.org/1764723002/#ps20001
(title: " ")

[commit-bot: I haz the power, 2016-03-04 23:45:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1764723002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1764723002/20001

[commit-bot: I haz the power, 2016-03-04 23:48:07]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-04 23:49:17]

Description was changed from

==========
[wasm] Remove TableSwitch and replace with br_table.

R=rossberg@chromium.org,binji@chromium.org,bradnelson@chromium.org
BUG=
==========

to

==========
[wasm] Remove TableSwitch and replace with br_table.

R=rossberg@chromium.org,binji@chromium.org,bradnelson@chromium.org
BUG=

Committed: https://crrev.com/bcfa400306bf74e380c7bc38cd5cab498c7d224c
Cr-Commit-Position: refs/heads/master@{#34511}
==========

[commit-bot: I haz the power, 2016-03-04 23:49:18]

Patchset 2 (id:??) landed as
https://crrev.com/bcfa400306bf74e380c7bc38cd5cab498c7d224c
Cr-Commit-Position: refs/heads/master@{#34511}