Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 1764693005: Revert of Use px in color-profile-{background-clip-text,svg-fill-text}.html (Closed)

Created:
4 years, 9 months ago by Marc Treib
Modified:
4 years, 9 months ago
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Use px in color-profile-{background-clip-text,svg-fill-text}.html (patchset #1 id:1 of https://codereview.chromium.org/1761293002/ ) Reason for revert: Broke webkit_lint on all the bots. What was the justification for NOPRESUBMIT and NOTRY here? Original issue's description: > Use px in color-profile-{background-clip-text,svg-fill-text}.html > > Use px for font size and positions in these tests to produce more > consistent rendering across ports (issue 591901), and request new > test rebaselines on all ports. > > TBR=dpranke@chromium.org > BUG=587737, 591901 > NOPRESUBMIT=true > NOTRY=true > > Committed: https://crrev.com/5982e29a45b6d2074d85daa86409c6065adfd8f4 > Cr-Commit-Position: refs/heads/master@{#379253} TBR=dpranke@chromium.org,noel@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=587737, 591901 Committed: https://crrev.com/4ed72916ddc16becae48e3ee861922d6de9b2136 Cr-Commit-Position: refs/heads/master@{#379266}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -8 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/images/color-profile-background-clip-text.html View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/images/color-profile-svg-fill-text.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Marc Treib
Created Revert of Use px in color-profile-{background-clip-text,svg-fill-text}.html
4 years, 9 months ago (2016-03-04 10:51:52 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1764693005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1764693005/1
4 years, 9 months ago (2016-03-04 10:52:05 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-04 10:52:35 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/4ed72916ddc16becae48e3ee861922d6de9b2136 Cr-Commit-Position: refs/heads/master@{#379266}
4 years, 9 months ago (2016-03-04 10:53:38 UTC) #6
Dirk Pranke
4 years, 9 months ago (2016-03-04 16:53:06 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698