Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(584)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1764693003: [Android] Add ability to configure known devices file for perf tests to android/perf.py (Closed)

Created:
4 years, 9 months ago by rnephew (Reviews Here)
Modified:
4 years, 9 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/remotes/origin/master
Project:
build
Visibility:
Public.

Description

[Android] Add ability to configure known devices file for perf tests to android/perf.py The first CL assumed that perf tests are run from chromium_test, which is wrong. BUG=590229 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299111

Patch Set 1 #

Total comments: 3

Patch Set 2 : make .known_devices default #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -49 lines) Patch
M scripts/slave/recipe_modules/chromium_tests/chromium_perf.py View 1 2 chunks +8 lines, -15 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_tests/steps.py View 1 chunk +4 lines, -5 lines 0 comments Download
M scripts/slave/recipes/android/perf.py View 1 3 chunks +6 lines, -4 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Galaxy_S5_Perf__1_.json View 1 chunk +3 lines, -1 line 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Galaxy_S5_Perf__2_.json View 1 chunk +3 lines, -1 line 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Galaxy_S5_Perf__3_.json View 1 chunk +3 lines, -1 line 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_Perf__1_.json View 1 chunk +3 lines, -1 line 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_Perf__2_.json View 1 chunk +3 lines, -1 line 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_Perf__3_.json View 1 chunk +3 lines, -1 line 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5_Perf__1_.json View 1 chunk +3 lines, -1 line 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5_Perf__2_.json View 1 chunk +3 lines, -1 line 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5_Perf__3_.json View 1 chunk +3 lines, -1 line 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus6_Perf__1_.json View 1 chunk +3 lines, -1 line 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus6_Perf__2_.json View 1 chunk +3 lines, -1 line 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus6_Perf__3_.json View 1 chunk +3 lines, -1 line 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus7v2_Perf__1_.json View 1 chunk +3 lines, -1 line 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus7v2_Perf__2_.json View 1 chunk +3 lines, -1 line 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus7v2_Perf__3_.json View 1 chunk +3 lines, -1 line 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus9_Perf__1_.json View 1 chunk +3 lines, -1 line 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus9_Perf__2_.json View 1 chunk +3 lines, -1 line 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus9_Perf__3_.json View 1 chunk +3 lines, -1 line 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_One_Perf__1_.json View 1 chunk +3 lines, -1 line 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_One_Perf__2_.json View 1 chunk +3 lines, -1 line 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_One_Perf__3_.json View 1 chunk +3 lines, -1 line 0 comments Download
M scripts/slave/recipes/android/perf.expected/get_perf_test_list_old_data.json View 1 chunk +3 lines, -1 line 0 comments Download
M scripts/slave/recipes/android/perf.expected/missing_device.json View 1 chunk +3 lines, -1 line 0 comments Download
M scripts/slave/recipes/android/perf.expected/src_side_script_fails.json View 1 chunk +3 lines, -1 line 0 comments Download
M scripts/slave/recipes/android/perf.expected/test_failure.json View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 12 (3 generated)
rnephew (Wrong account)
4 years, 9 months ago (2016-03-03 20:24:32 UTC) #2
dtu
https://codereview.chromium.org/1764693003/diff/1/scripts/slave/recipes/android/perf.py File scripts/slave/recipes/android/perf.py (right): https://codereview.chromium.org/1764693003/diff/1/scripts/slave/recipes/android/perf.py#newcode63 scripts/slave/recipes/android/perf.py:63: known_devices_file='.known_devices') Does it need to be specified at this ...
4 years, 9 months ago (2016-03-04 00:05:15 UTC) #3
rnephew (Reviews Here)
https://codereview.chromium.org/1764693003/diff/1/scripts/slave/recipes/android/perf.py File scripts/slave/recipes/android/perf.py (right): https://codereview.chromium.org/1764693003/diff/1/scripts/slave/recipes/android/perf.py#newcode63 scripts/slave/recipes/android/perf.py:63: known_devices_file='.known_devices') On 2016/03/04 00:05:15, dtu wrote: > Does it ...
4 years, 9 months ago (2016-03-04 00:11:13 UTC) #4
rnephew (Reviews Here)
https://codereview.chromium.org/1764693003/diff/1/scripts/slave/recipes/android/perf.py File scripts/slave/recipes/android/perf.py (right): https://codereview.chromium.org/1764693003/diff/1/scripts/slave/recipes/android/perf.py#newcode63 scripts/slave/recipes/android/perf.py:63: known_devices_file='.known_devices') On 2016/03/04 00:11:13, rnephew1 wrote: > On 2016/03/04 ...
4 years, 9 months ago (2016-03-04 00:12:31 UTC) #5
rnephew (Reviews Here)
On 2016/03/04 00:12:31, rnephew1 wrote: > https://codereview.chromium.org/1764693003/diff/1/scripts/slave/recipes/android/perf.py > File scripts/slave/recipes/android/perf.py (right): > > https://codereview.chromium.org/1764693003/diff/1/scripts/slave/recipes/android/perf.py#newcode63 > ...
4 years, 9 months ago (2016-03-04 00:42:39 UTC) #6
dtu
lgtm
4 years, 9 months ago (2016-03-04 00:45:14 UTC) #7
Paweł Hajdan Jr.
LGTM
4 years, 9 months ago (2016-03-04 07:48:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1764693003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1764693003/20001
4 years, 9 months ago (2016-03-04 16:51:57 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-04 16:56:43 UTC) #12
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=299111

Powered by Google App Engine
This is Rietveld 408576698