Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Issue 1764693002: Reland of Instantiate instance templates instead of doing construct calls (Closed)

Created:
4 years, 9 months ago by Ken Russell (switch to Gerrit)
Modified:
4 years, 9 months ago
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Instantiate instance templates instead of doing construct calls (patchset #1 id:1 of https://codereview.chromium.org/1753363002/ ) Reason for revert: This wasn't the cause of the test failures; see http://crbug.com/591705 . It must have been a different CL. Original issue's description: > Revert of Instantiate instance templates instead of doing construct calls (patchset #1 id:1 of https://codereview.chromium.org/1747293002/ ) > > Reason for revert: > It looks like this caused the WebglConformance.conformance_misc_expando_loss test to start failing (only on Win x64, strangely). This test verifies that expando properties added to JavaScript instances which are kept alive via hidden properties are preserved during GC: > https://build.chromium.org/p/chromium.gpu.fyi/builders/Win7%20x64%20Debug%20%28NVIDIA%29/builds/614 > > In the future it would be really helpful if you filed bugs about changes like this so that lands, reverts and re-lands were all referenced from one place. > > Original issue's description: > > Instantiate instance templates instead of doing construct calls > > > > This reduces the calls to V8 to create new wrappers. We also don't rely > > on invoking the function anyways, but instead cache results. > > > > BUG= > > R=verwaest@chromium.org > > > > Committed: https://crrev.com/5800d1a48a2f4c2aab7cf875b164b08328c7acf4 > > Cr-Commit-Position: refs/heads/master@{#378497} > > TBR=verwaest@chromium.org,jochen@chromium.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG= > NOTRY=true > > Committed: https://crrev.com/6987deba28b2c7bb58dceffc21223f7ff4ec5e7a > Cr-Commit-Position: refs/heads/master@{#378874} TBR=verwaest@chromium.org,jochen@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/76c7dc9b28d7c5f5bd7c204275375b9ee3234192 Cr-Commit-Position: refs/heads/master@{#379024}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/V8DOMWrapper.cpp View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Ken Russell (switch to Gerrit)
Created Reland of Instantiate instance templates instead of doing construct calls
4 years, 9 months ago (2016-03-03 17:03:17 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1764693002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1764693002/1
4 years, 9 months ago (2016-03-03 17:03:33 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-03 17:04:02 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/76c7dc9b28d7c5f5bd7c204275375b9ee3234192 Cr-Commit-Position: refs/heads/master@{#379024}
4 years, 9 months ago (2016-03-03 17:05:40 UTC) #6
haraken
4 years, 9 months ago (2016-03-03 22:28:50 UTC) #7
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698