Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 1764613004: [rutime] Simplify undetectable handling in Object::Equals. (Closed)

Created:
4 years, 9 months ago by Benedikt Meurer
Modified:
4 years, 9 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[rutime] Simplify undetectable handling in Object::Equals. According to https://www.w3.org/TR/html5/obsolete.html#dom-document-all the undetectable bit (for document.all) only affects comparisons with undefined and null. In particular comparisons with other values are not affected, so we can actually simplify the handling of undetectable a lot by only checking it when null or undefined might be involved (this is actually in line with what the CompareIC does). CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel R=verwaest@chromium.org Committed: https://crrev.com/e0750529760de8a1bfe344dd5c0d92a9ac453849 Cr-Commit-Position: refs/heads/master@{#34483}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M src/objects.cc View 6 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Benedikt Meurer
4 years, 9 months ago (2016-03-04 07:40:17 UTC) #1
Benedikt Meurer
Hey Toon, Simplify the Object::Equals primitive a bit wrt. undetectable. Please take a look. Thanks, ...
4 years, 9 months ago (2016-03-04 07:42:06 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1764613004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1764613004/1
4 years, 9 months ago (2016-03-04 07:42:44 UTC) #5
Toon Verwaest
lgtm
4 years, 9 months ago (2016-03-04 07:44:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1764613004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1764613004/1
4 years, 9 months ago (2016-03-04 07:47:04 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-04 09:08:06 UTC) #11
commit-bot: I haz the power
4 years, 9 months ago (2016-03-04 09:09:43 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e0750529760de8a1bfe344dd5c0d92a9ac453849
Cr-Commit-Position: refs/heads/master@{#34483}

Powered by Google App Engine
This is Rietveld 408576698