Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Unified Diff: src/compiler/wasm-compiler.cc

Issue 1764603003: Handle stack frames differently inside and on the boundary of wasm. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: fix Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/frames.h » ('j') | src/objects.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/wasm-compiler.cc
diff --git a/src/compiler/wasm-compiler.cc b/src/compiler/wasm-compiler.cc
index 893cde4802d1cc447ea833a121a4af3d4a77c86e..0d2619773f5db26530a8bf451c7805f727cf1f33 100644
--- a/src/compiler/wasm-compiler.cc
+++ b/src/compiler/wasm-compiler.cc
@@ -2233,8 +2233,8 @@ Handle<JSFunction> CompileJSToWasmWrapper(
module->GetFunctionSignature(index)->parameter_count());
CallDescriptor* incoming = Linkage::GetJSCallDescriptor(
&zone, false, params + 1, CallDescriptor::kNoFlags);
- // TODO(titzer): this is technically a WASM wrapper, not a wasm function.
- Code::Flags flags = Code::ComputeFlags(Code::WASM_FUNCTION);
+ Code::Flags flags =
+ Code::ComputeWasmFlags(Code::WASM_FUNCTION, Code::JS_TO_WASM);
bool debugging =
#if DEBUG
true;
@@ -2313,8 +2313,8 @@ Handle<Code> CompileWasmToJSWrapper(Isolate* isolate, wasm::ModuleEnv* module,
// Schedule and compile to machine code.
CallDescriptor* incoming =
wasm::ModuleEnv::GetWasmCallDescriptor(&zone, sig);
- // TODO(titzer): this is technically a WASM wrapper, not a wasm function.
- Code::Flags flags = Code::ComputeFlags(Code::WASM_FUNCTION);
+ Code::Flags flags =
+ Code::ComputeWasmFlags(Code::WASM_FUNCTION, Code::WASM_TO_JS);
bool debugging =
#if DEBUG
true;
@@ -2398,7 +2398,7 @@ Handle<Code> CompileWasmFunction(wasm::ErrorThrower& thrower, Isolate* isolate,
if (kPointerSize == 4) {
descriptor = module_env->GetI32WasmCallDescriptor(&zone, descriptor);
}
- Code::Flags flags = Code::ComputeFlags(Code::WASM_FUNCTION);
+ Code::Flags flags = Code::ComputeWasmFlags(Code::WASM_FUNCTION);
// add flags here if a meaningful name is helpful for debugging.
bool debugging =
#if DEBUG
« no previous file with comments | « no previous file | src/frames.h » ('j') | src/objects.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698