Added ROBUST_PNG_CODEC to ImageDecoder

Added ROBUST_PNG_CODEC to ImageDecoder

ROBUST_JPEG_CODEC was added in the past because using the default
decoder, that accepts various image formats, in login screens
is potentially dangerous.

However, JPEG format does not support transparent pixels, hence
profile images with transparent pixels are rendered incorrectly.

Per discussion with jorgelo@ and mdempsky@, this patch introduces
ROBUST_PNG_CODEC, that accepts only PNG data on top of the libpng
decoder.

BUG=587289
TEST=run the newly added browser tests

Committed: https://crrev.com/f7e76f065f7ee1843fd82753ec998bf95ccc1b7b
Cr-Commit-Position: refs/heads/master@{#380086}

[satorux1, 2016-03-03 06:27:00]

satorux@chromium.org changed reviewers:
+ jorgelo@chromium.org, mdempsky@chromium.org

[mdempsky, 2016-03-03 07:34:36]

lgtm

[Jorge Lucangeli Obes, 2016-03-03 17:57:52]

lgtm

[satorux1, 2016-03-04 05:12:21]

satorux@chromium.org changed reviewers:
+ thestig@chromium.org

[satorux1, 2016-03-04 05:12:21]

+thestig@ please take a look once you are back.

[Lei Zhang, 2016-03-08 23:38:00]

lgtm

https://codereview.chromium.org/1764603002/diff/40001/chrome/browser/image_de...
File chrome/browser/image_decoder_browsertest.cc (right):

https://codereview.chromium.org/1764603002/diff/40001/chrome/browser/image_de...
chrome/browser/image_decoder_browsertest.cc:60: #endif // defined(OS_CHROMEOS)
nit: add extra space, run git cl lint.

[satorux1, 2016-03-09 05:28:18]

https://codereview.chromium.org/1764603002/diff/40001/chrome/browser/image_de...
File chrome/browser/image_decoder_browsertest.cc (right):

https://codereview.chromium.org/1764603002/diff/40001/chrome/browser/image_de...
chrome/browser/image_decoder_browsertest.cc:60: #endif // defined(OS_CHROMEOS)
On 2016/03/08 23:37:59, Lei Zhang (OOO) wrote:
> nit: add extra space, run git cl lint.

Done.

[satorux1, 2016-03-09 05:51:38]

The CQ bit was checked by satorux@chromium.org

[satorux1, 2016-03-09 05:51:38]

The patchset sent to the CQ was uploaded after l-g-t-m from
jorgelo@chromium.org, mdempsky@chromium.org, thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/1764603002/#ps80001
(title: "address comments")

[commit-bot: I haz the power, 2016-03-09 05:51:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1764603002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1764603002/80001

[commit-bot: I haz the power, 2016-03-09 06:30:53]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-03-09 06:32:01]

Description was changed from

==========
Added ROBUST_PNG_CODEC to ImageDecoder

ROBUST_JPEG_CODEC was added in the past because using the default
decoder, that accepts various image formats, in login screens
is potentially dangerous.

However, JPEG format does not support transparent pixels, hence
profile images with transparent pixels are rendered incorrectly.

Per discussion with jorgelo@ and mdempsky@, this patch introduces
ROBUST_PNG_CODEC, that accepts only PNG data on top of the libpng
decoder.

BUG=587289
TEST=run the newly added browser tests
==========

to

==========
Added ROBUST_PNG_CODEC to ImageDecoder

ROBUST_JPEG_CODEC was added in the past because using the default
decoder, that accepts various image formats, in login screens
is potentially dangerous.

However, JPEG format does not support transparent pixels, hence
profile images with transparent pixels are rendered incorrectly.

Per discussion with jorgelo@ and mdempsky@, this patch introduces
ROBUST_PNG_CODEC, that accepts only PNG data on top of the libpng
decoder.

BUG=587289
TEST=run the newly added browser tests

Committed: https://crrev.com/f7e76f065f7ee1843fd82753ec998bf95ccc1b7b
Cr-Commit-Position: refs/heads/master@{#380086}
==========

[commit-bot: I haz the power, 2016-03-09 06:32:03]

Patchset 5 (id:??) landed as
https://crrev.com/f7e76f065f7ee1843fd82753ec998bf95ccc1b7b
Cr-Commit-Position: refs/heads/master@{#380086}