Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Issue 1764593002: [deoptimizer] Removed dynamic frame alignment support. (Closed)

Created:
4 years, 9 months ago by Igor Sheludko
Modified:
4 years, 9 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[deoptimizer] Removed dynamic frame alignment support. The support was already removed from the Crankshaft and this CL removes the last piece. Committed: https://crrev.com/e982f95023acb4b7e92d00af30ebaf14af1ea5a5 Cr-Commit-Position: refs/heads/master@{#34456}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -92 lines) Patch
M src/arm/deoptimizer-arm.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/arm64/deoptimizer-arm64.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/deoptimizer.h View 3 chunks +0 lines, -9 lines 0 comments Download
M src/deoptimizer.cc View 6 chunks +12 lines, -30 lines 0 comments Download
M src/ia32/deoptimizer-ia32.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/mips/deoptimizer-mips.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/mips64/deoptimizer-mips64.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/ppc/deoptimizer-ppc.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/s390/deoptimizer-s390.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/x64/deoptimizer-x64.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/x87/deoptimizer-x87.cc View 1 chunk +0 lines, -6 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1764593002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1764593002/1
4 years, 9 months ago (2016-03-03 06:21:27 UTC) #2
Igor Sheludko
PTAL and CQ
4 years, 9 months ago (2016-03-03 06:45:05 UTC) #4
Benedikt Meurer
Awesome! Kill it with fire. LGTM
4 years, 9 months ago (2016-03-03 06:55:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1764593002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1764593002/1
4 years, 9 months ago (2016-03-03 06:56:01 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-03 07:00:47 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-03 07:01:55 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e982f95023acb4b7e92d00af30ebaf14af1ea5a5
Cr-Commit-Position: refs/heads/master@{#34456}

Powered by Google App Engine
This is Rietveld 408576698