Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 1764503003: Suppress deprecation warnings for XFA. (Closed)

Created:
4 years, 9 months ago by Tom Sepez
Modified:
4 years, 9 months ago
Reviewers:
dsinclair
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Suppress deprecation warnings for XFA. Temporary measure until FX fixes these (or I do). This is blocking rolling XFA into chrome. R=dsinclair@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/88aa3a76d309e8192a206e40d418294d89f35adb

Patch Set 1 #

Total comments: 1

Patch Set 2 : Conditionalize. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M xfa.gyp View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Tom Sepez
Dan, for review.
4 years, 9 months ago (2016-03-03 20:59:18 UTC) #3
dsinclair
https://codereview.chromium.org/1764503003/diff/1/xfa.gyp File xfa.gyp (right): https://codereview.chromium.org/1764503003/diff/1/xfa.gyp#newcode24 xfa.gyp:24: # TODO(tsepez): remove this when FX fixes warnings nit: ...
4 years, 9 months ago (2016-03-03 21:08:13 UTC) #4
dsinclair
lgtm
4 years, 9 months ago (2016-03-03 21:09:30 UTC) #5
Tom Sepez
4 years, 9 months ago (2016-03-03 21:10:25 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
88aa3a76d309e8192a206e40d418294d89f35adb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698