Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Unified Diff: remoting/client/jni/chromoting_jni_runtime.cc

Issue 1764503002: Adding container class for chromoting client runtimes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removing ios version, using runtime in jni runtime. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/client/jni/chromoting_jni_runtime.cc
diff --git a/remoting/client/jni/chromoting_jni_runtime.cc b/remoting/client/jni/chromoting_jni_runtime.cc
index b1b36b77e14df758a0ad6d7059dbac4e0ed5c54e..2f946be3dddbb146fc45ccae6a242e246690fda1 100644
--- a/remoting/client/jni/chromoting_jni_runtime.cc
+++ b/remoting/client/jni/chromoting_jni_runtime.cc
@@ -213,39 +213,25 @@ ChromotingJniRuntime* ChromotingJniRuntime::GetInstance() {
}
ChromotingJniRuntime::ChromotingJniRuntime() {
- // On Android, the UI thread is managed by Java, so we need to attach and
- // start a special type of message loop to allow Chromium code to run tasks.
- ui_loop_.reset(new base::MessageLoopForUI());
- ui_loop_->Start();
-
- // TODO(solb) Stop pretending to control the managed UI thread's lifetime.
- ui_task_runner_ = new AutoThreadTaskRunner(
- ui_loop_->task_runner(), base::MessageLoop::QuitWhenIdleClosure());
- network_task_runner_ = AutoThread::CreateWithType("native_net",
- ui_task_runner_,
- base::MessageLoop::TYPE_IO);
- display_task_runner_ = AutoThread::Create("native_disp",
- ui_task_runner_);
-
- url_requester_ =
- new URLRequestContextGetter(network_task_runner_, network_task_runner_);
+ // Grab or create the threads.
+ runtime_ = ChromotingClientRuntime::GetInstance();
}
ChromotingJniRuntime::~ChromotingJniRuntime() {
// The singleton should only ever be destroyed on the main thread.
- DCHECK(ui_task_runner_->BelongsToCurrentThread());
+ DCHECK(ui_task_runner()->BelongsToCurrentThread());
// The session must be shut down first, since it depends on our other
// components' still being alive.
DisconnectFromHost();
base::WaitableEvent done_event(false, false);
- network_task_runner_->PostTask(FROM_HERE, base::Bind(
+ network_task_runner()->PostTask(FROM_HERE, base::Bind(
&ChromotingJniRuntime::DetachFromVmAndSignal,
base::Unretained(this),
&done_event));
done_event.Wait();
- display_task_runner_->PostTask(FROM_HERE, base::Bind(
+ display_task_runner()->PostTask(FROM_HERE, base::Bind(
&ChromotingJniRuntime::DetachFromVmAndSignal,
base::Unretained(this),
&done_event));
@@ -263,7 +249,7 @@ void ChromotingJniRuntime::ConnectToHost(const std::string& username,
const std::string& pairing_secret,
const std::string& capabilities,
const std::string& flags) {
- DCHECK(ui_task_runner_->BelongsToCurrentThread());
+ DCHECK(ui_task_runner()->BelongsToCurrentThread());
DCHECK(!session_.get());
session_ = new ChromotingJniInstance(this, username, auth_token, host_jid,
host_id, host_pubkey, pairing_id,
@@ -271,7 +257,7 @@ void ChromotingJniRuntime::ConnectToHost(const std::string& username,
}
void ChromotingJniRuntime::DisconnectFromHost() {
- DCHECK(ui_task_runner_->BelongsToCurrentThread());
+ DCHECK(ui_task_runner()->BelongsToCurrentThread());
if (session_.get()) {
session_->Disconnect();
session_ = nullptr;
@@ -281,14 +267,14 @@ void ChromotingJniRuntime::DisconnectFromHost() {
void ChromotingJniRuntime::OnConnectionState(
protocol::ConnectionToHost::State state,
protocol::ErrorCode error) {
- DCHECK(ui_task_runner_->BelongsToCurrentThread());
+ DCHECK(ui_task_runner()->BelongsToCurrentThread());
JNIEnv* env = base::android::AttachCurrentThread();
Java_JniInterface_onConnectionState(env, state, error);
}
void ChromotingJniRuntime::DisplayAuthenticationPrompt(bool pairing_supported) {
- DCHECK(ui_task_runner_->BelongsToCurrentThread());
+ DCHECK(ui_task_runner()->BelongsToCurrentThread());
JNIEnv* env = base::android::AttachCurrentThread();
Java_JniInterface_displayAuthenticationPrompt(env, pairing_supported);
@@ -297,7 +283,7 @@ void ChromotingJniRuntime::DisplayAuthenticationPrompt(bool pairing_supported) {
void ChromotingJniRuntime::CommitPairingCredentials(const std::string& host,
const std::string& id,
const std::string& secret) {
- DCHECK(ui_task_runner_->BelongsToCurrentThread());
+ DCHECK(ui_task_runner()->BelongsToCurrentThread());
JNIEnv* env = base::android::AttachCurrentThread();
ScopedJavaLocalRef<jstring> j_host = ConvertUTF8ToJavaString(env, host);
@@ -311,7 +297,7 @@ void ChromotingJniRuntime::CommitPairingCredentials(const std::string& host,
void ChromotingJniRuntime::FetchThirdPartyToken(const GURL& token_url,
const std::string& client_id,
const std::string& scope) {
- DCHECK(ui_task_runner_->BelongsToCurrentThread());
+ DCHECK(ui_task_runner()->BelongsToCurrentThread());
JNIEnv* env = base::android::AttachCurrentThread();
ScopedJavaLocalRef<jstring> j_url =
@@ -325,7 +311,7 @@ void ChromotingJniRuntime::FetchThirdPartyToken(const GURL& token_url,
}
void ChromotingJniRuntime::SetCapabilities(const std::string& capabilities) {
- DCHECK(ui_task_runner_->BelongsToCurrentThread());
+ DCHECK(ui_task_runner()->BelongsToCurrentThread());
JNIEnv* env = base::android::AttachCurrentThread();
ScopedJavaLocalRef<jstring> j_cap =
@@ -336,7 +322,7 @@ void ChromotingJniRuntime::SetCapabilities(const std::string& capabilities) {
void ChromotingJniRuntime::HandleExtensionMessage(const std::string& type,
const std::string& message) {
- DCHECK(ui_task_runner_->BelongsToCurrentThread());
+ DCHECK(ui_task_runner()->BelongsToCurrentThread());
JNIEnv* env = base::android::AttachCurrentThread();
ScopedJavaLocalRef<jstring> j_type = ConvertUTF8ToJavaString(env, type);
@@ -352,7 +338,7 @@ base::android::ScopedJavaLocalRef<jobject> ChromotingJniRuntime::NewBitmap(
}
void ChromotingJniRuntime::UpdateFrameBitmap(jobject bitmap) {
- DCHECK(display_task_runner_->BelongsToCurrentThread());
+ DCHECK(display_task_runner()->BelongsToCurrentThread());
JNIEnv* env = base::android::AttachCurrentThread();
Java_JniInterface_setVideoFrame(env, bitmap);
@@ -360,7 +346,7 @@ void ChromotingJniRuntime::UpdateFrameBitmap(jobject bitmap) {
void ChromotingJniRuntime::UpdateCursorShape(
const protocol::CursorShapeInfo& cursor_shape) {
- DCHECK(display_task_runner_->BelongsToCurrentThread());
+ DCHECK(display_task_runner()->BelongsToCurrentThread());
// const_cast<> is safe as long as the Java updateCursorShape() method copies
// the data out of the buffer without mutating it, and doesn't keep any
@@ -382,7 +368,7 @@ void ChromotingJniRuntime::UpdateCursorShape(
}
void ChromotingJniRuntime::RedrawCanvas() {
- DCHECK(display_task_runner_->BelongsToCurrentThread());
+ DCHECK(display_task_runner()->BelongsToCurrentThread());
JNIEnv* env = base::android::AttachCurrentThread();
Java_JniInterface_redrawGraphicsInternal(env);

Powered by Google App Engine
This is Rietveld 408576698