Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1764483003: Changes ownership of ClientConnection (Closed)

Created:
4 years, 9 months ago by sky
Modified:
4 years, 9 months ago
CC:
chromium-reviews, rjkroege
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Changes ownership of ClientConnection Previously ClientConnection owned the WindowTreeImpl. This is mildly confusing and weird. Now WindowTreeImpl owns the ClientConnection and ConnectionManager owns the WindowTreeImpls. As part of this I also changed around how WindowTreeImpls are created. BUG=590955 TEST=covered by tests R=ben@chromium.org Committed: https://crrev.com/464574d96d15eeb2c984fcd025d5f1cb7da34594 Cr-Commit-Position: refs/heads/master@{#378961}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+225 lines, -266 lines) Patch
M components/mus/mus_app.h View 1 chunk +2 lines, -9 lines 0 comments Download
M components/mus/mus_app.cc View 1 chunk +4 lines, -32 lines 0 comments Download
M components/mus/ws/client_connection.h View 2 chunks +6 lines, -9 lines 0 comments Download
M components/mus/ws/client_connection.cc View 1 chunk +12 lines, -10 lines 0 comments Download
M components/mus/ws/connection_manager.h View 3 chunks +14 lines, -10 lines 0 comments Download
M components/mus/ws/connection_manager.cc View 15 chunks +106 lines, -89 lines 0 comments Download
M components/mus/ws/connection_manager_delegate.h View 3 chunks +5 lines, -11 lines 0 comments Download
M components/mus/ws/window_tree_factory.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M components/mus/ws/window_tree_host_impl.cc View 2 chunks +2 lines, -8 lines 0 comments Download
M components/mus/ws/window_tree_impl.h View 4 chunks +5 lines, -3 lines 0 comments Download
M components/mus/ws/window_tree_impl.cc View 36 chunks +56 lines, -59 lines 0 comments Download
M components/mus/ws/window_tree_unittest.cc View 3 chunks +10 lines, -24 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
sky
4 years, 9 months ago (2016-03-03 00:41:24 UTC) #1
Ben Goodger (Google)
lgtm
4 years, 9 months ago (2016-03-03 01:50:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1764483003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1764483003/1
4 years, 9 months ago (2016-03-03 04:21:38 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-03 05:08:44 UTC) #5
commit-bot: I haz the power
4 years, 9 months ago (2016-03-03 05:09:43 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/464574d96d15eeb2c984fcd025d5f1cb7da34594
Cr-Commit-Position: refs/heads/master@{#378961}

Powered by Google App Engine
This is Rietveld 408576698